Skip to content

Fix for SWs with same Action= shadowing each other #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Templarfreak wants to merge 5 commits into
base: main
Choose a base branch
from
+21 −3
Open

Fix for SWs with same Action= shadowing each other #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2fc07eb
Fix for SWs with same Action= shadowing each other
Templarfreak Aug 29, 2026
15063c8
ow-power, SW being removed, etc
Templarfreak Aug 30, 2026
00515e5
Create fix-sw-shadowing.md
Templarfreak Aug 30, 2026
38813cc
Use IsTargettingMode Instead
Templarfreak Sep 2, 2026
bf36703
Update fix-sw-shadowing.md
Templarfreak Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions code/display.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2427,9 +2427,11 @@ void DisplayClass::Mouse_Left_Release(Coord const & coord, Cell const & cell, Ob
}
}

SuperWeaponTypeClass *stype = SuperWeaponTypeClass::From_Action(action);
if (stype != NULL) {
OutList.push_back(EventClass(PlayerPtr->HeapID, EventClass::SPECIAL_PLACE, stype->HeapID, cell));
if (IsTargettingMode != SUPER_NONE) {
SuperWeaponTypeClass *stype = SuperWeaponTypes[IsTargettingMode];
if (stype != NULL) {
OutList.push_back(EventClass(PlayerPtr->HeapID, EventClass::SPECIAL_PLACE, stype->HeapID, cell));
}
}
}

Expand Down
16 changes: 16 additions & 0 deletions manual/changes/fix-sw-shadowing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
title: Keep superweapons that share an Action from replacing each other
category: fix
release: 0.2.0
targets:
- type: system
id: superweapons
effect: changed
credit: [Templarfreak]
---

Placing a superweapon on the map now fires the one that was actually armed, even when
another superweapon defines the same Action. Clicking a target cell previously resolved
back to whichever superweapon type first matched that Action, so two superweapons sharing
one Action value could not be fired independently: placing either one always discharged
the same type and left the other's charge untouched.