Skip to content

Translate sos adpcm codecs directly from ASM to C++ - #85

Merged
ZivDero merged 8 commits into
OpenTS-Developers:mainfrom
tinix0:translate-sos-adpcm-codecs-simple
Sep 1, 2026
Merged

Translate sos adpcm codecs directly from ASM to C++#85
ZivDero merged 8 commits into
OpenTS-Developers:mainfrom
tinix0:translate-sos-adpcm-codecs-simple

Conversation

@tinix0

@tinix0 tinix0 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Direct translation from assembly to C++ of the SOS ADPCM codec code. Includes unit tests with vector outputs generated by the original assembly code for verification.

tinix0 added 4 commits August 31, 2026 07:42
No documentation update: tests/sosparity checks the C++ codec against golden vectors recorded from the original assembly, so documented audio behavior is unchanged.
@tinix0
tinix0 force-pushed the translate-sos-adpcm-codecs-simple branch from 87f57a1 to f0a23bd Compare August 31, 2026 05:42
@tomsons26

tomsons26 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The codebase doesn't use the modern types, if you see a long make it a int.
Make the _SOS_COMPRESS_INFO channels members a struct so its Channels[2]
Left_Channel, Right_Channel is a very pointless thing to do if you could just pass the channel struct after the previously suggested change.

@ZivDero

ZivDero commented Aug 31, 2026

Copy link
Copy Markdown
Member

The codebase doesn't use the modern types, if you see a long make it a int. Make the channels a struct so its Channels[2] Left_Channel, Right_Channel is a very pointless thing to do if you could just pass the channel struct after the previously suggested change.

Imo using modern types is fine.

Comment thread code/soscodec.cpp Outdated
Comment thread code/soscodec_tables.h Outdated
Comment thread code/soscodec.cpp Outdated
@tinix0
tinix0 requested a review from tomsons26 August 31, 2026 13:18
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

Development builds of 6b3a6fe:

The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build.

Comment thread code/soscodec.cpp
Comment thread code/soscodec_tables.h Outdated
Comment thread code/soscodec.cpp Outdated
Comment thread code/soscodec.cpp Outdated
@tinix0
tinix0 requested a review from tomsons26 August 31, 2026 20:18
@ZivDero
ZivDero merged commit 5a841c8 into OpenTS-Developers:main Sep 1, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants