Translate sos adpcm codecs directly from ASM to C++ - #85
Merged
ZivDero merged 8 commits intoSep 1, 2026
Conversation
No documentation update: tests/sosparity checks the C++ codec against golden vectors recorded from the original assembly, so documented audio behavior is unchanged.
tinix0
force-pushed
the
translate-sos-adpcm-codecs-simple
branch
from
August 31, 2026 05:42
87f57a1 to
f0a23bd
Compare
Contributor
|
The codebase doesn't use the modern types, if you see a long make it a int. |
Member
Imo using modern types is fine. |
tomsons26
reviewed
Aug 31, 2026
tomsons26
reviewed
Aug 31, 2026
tomsons26
reviewed
Aug 31, 2026
|
Development builds of 6b3a6fe: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
tomsons26
reviewed
Aug 31, 2026
tomsons26
reviewed
Aug 31, 2026
tomsons26
reviewed
Aug 31, 2026
tomsons26
reviewed
Aug 31, 2026
tomsons26
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct translation from assembly to C++ of the SOS ADPCM codec code. Includes unit tests with vector outputs generated by the original assembly code for verification.