Make Random3 seed table values explicitly signed - #99
Merged
ZivDero merged 1 commit intoAug 31, 2026
Merged
Conversation
The tables store signed 32-bit values, but entries above INT_MAX used unsigned hexadecimal literals and relied on compiler-specific narrowing. Express them as equivalent negative values while preserving every 32-bit bit pattern.
|
Development builds of d24ad98: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
5 tasks
mischa85
pushed a commit
to mischa85/OpenTS
that referenced
this pull request
Aug 31, 2026
The tables store signed 32-bit values, but entries above INT_MAX used unsigned hexadecimal literals and relied on compiler-specific narrowing. Express them as equivalent negative values while preserving every 32-bit bit pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tables store signed 32-bit values, but entries above INT_MAX used unsigned hexadecimal literals and relied on compiler-specific narrowing. Express them as equivalent negative values while preserving every 32-bit bit pattern.
Required for #80