Skip to content

Change: Do not scan for similar filepaths if passed one is accessible - #450

Merged
2TallTyler merged 1 commit into
OpenTTD:masterfrom
Pixel-Tony:fix/find_file
Nov 12, 2026
Merged

2TallTyler merged 1 commit into
OpenTTD:masterfrom
Pixel-Tony:fix/find_file

Conversation

@Pixel-Tony

Copy link
Copy Markdown
Contributor

Fixes the issue discussed in #440. The passed file path is returned as is if the corresponding file exists and is accessible; otherwise, an attempt to find case-insensitive version is conducted but a script error is raised/thrown instead.

@Pixel-Tony
Pixel-Tony force-pushed the fix/find_file branch 3 times, most recently from 707e0e9 to ac3014d Compare October 13, 2026 21:30
@Pixel-Tony Pixel-Tony changed the title Change: Do not scan for similar filepaths if passed one is accessible… Change: Do not scan for similar filepaths if passed one is accessible Oct 13, 2026
@PeterN

PeterN commented Oct 16, 2026

Copy link
Copy Markdown
Member

This will remove the case-insensitivity (mis-)feature which in my opinion is not a problem, but others may disagree.

PeterN
PeterN previously approved these changes Oct 16, 2026
Comment thread nml/generic.py Resolved
@Pixel-Tony

Copy link
Copy Markdown
Contributor Author

@PeterN I rebased on recent commits in master; reapprove, please

@PeterN PeterN left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same caveat as before of course :-)

@2TallTyler
2TallTyler merged commit 3458878 into OpenTTD:master Nov 12, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants