Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions nml/ast/item.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,17 @@ def register_names(self):
)
self.id = existing_id
else:
casefoldedname = self.name.value.casefold()
for key in global_constants.item_names:
if casefoldedname == key.casefold():
generic.print_warning(
generic.Warning.GENERIC,
f"Item with name '{self.name.value}' similar to existing name '{key}'",
self.pos,
)
break
casefolded_name = self.name.value.casefold()
existing_name = global_constants.item_names_guard.get(casefolded_name)

if existing_name is not None:
generic.print_warning(
generic.Warning.GENERIC,
f"Item with name '{self.name.value}' similar to existing name '{existing_name}'",
self.pos,
)
else:
global_constants.item_names_guard[casefolded_name] = self.name.value

# We may have to reserve multiple item IDs for houses
num_ids = action0.house_sizes[self.size.value] if self.size is not None else 1
Expand Down
2 changes: 2 additions & 0 deletions nml/global_constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -1464,6 +1464,8 @@ def create_spritegroup_ref(name, info, pos):

identifier_refcount = {}
item_names = {}
# cache used for tracking casefolded names to prevent case-insenstive duplicate names
item_names_guard = {}
settings = {}
named_parameters = {}
spritegroups = {"CB_FAILED": "CB_FAILED"}
Expand Down
Loading