Repository navigation
Conversation
The instrumented tests are Hilt tests, but the compiler was only added with kspTest, so every one of them failed with a missing TestComponentDataSupplier. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ExfGKqc1qgteZLvhaNzew
Bundles SQLite 3.54.1, which fixes RUSTSEC-2026-0459 (CVE-2026-119375). Exploiting it requires opening a database and WAL file written by someone else, which can't happen with the app's private database, but the update is free. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ExfGKqc1qgteZLvhaNzew
The native library is about 70% of the APK, and nothing it does is performance sensitive. With opt-level z and a single codegen unit the stripped arm64 library shrinks from 8.3 MB to 4.8 MB, and the arm64 APK from 11.8 MB to 8.3 MB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ExfGKqc1qgteZLvhaNzew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small build and dependency changes. They came out of a larger Android UI change (#439) but don't depend on it, so they're split out here for easier review. Each commit stands on its own, so feel free to drop any of them.
android/app/build.gradle.ktslistedkspTest(libs.dagger.hilt.android.compiler)twice (once under "For instrumentation tests") and neverkspAndroidTest. Hilt therefore never generated the test components forandroidTest, and every instrumented test failed with a missingTestComponentDataSupplier. The first entry is nowkspAndroidTest.rusqlite0.40 → 0.41 andlibsqlite3-sys0.38 → 0.39, which bundles SQLite 3.54.1 and fixes RUSTSEC-2026-0459 (CVE-2026-119375). Exploiting it requires opening a database and WAL file written by someone else, which can't happen with the app's private database, so this isn't urgent, but the update is cheap.opt-level = "z"andcodegen-units = 1for therelease-androidprofile only, so desktop builds are unaffected. The native library is about 70% of the APK, and nothing in it is performance sensitive (it mostly parses and builds small Bluetooth packets). The stripped arm64-v8a library shrinks from 8.3 MB to 4.8 MB, and the arm64-v8a APK from 11.8 MB to 8.3 MB.Testing
Tested together with #439:
cargo test -p openscq30-lib --lib --features bundled-dependencies: 228/228 passedrelease-androidAPKAI disclosure
These changes were developed with the help of Claude (AI, via Claude Code), and the commits carry
Co-Authored-Bytrailers.🤖 Generated with Claude Code