ci: bump actions off the deprecated Node 20 runtime - #318
Open
mosherBT wants to merge 2 commits into
Open
Conversation
GitHub is retiring node20 on Actions runners, which annotates every job using setup-node@v4, upload-artifact@v4 and download-artifact@v4. checkout and cache were already current; these were missed. upload-artifact v5 and download-artifact v6 only had preliminary node24 support and still defaulted to node20, so v6/v7 respectively are the first releases that actually clear the warning. Bumped to latest. setup-node v5 auto-enables package-manager caching when package.json declares a packageManager, which is pnpm here. The setup-pnpm* composites run setup-node before pnpm exists and already cache the store themselves, so caching is disabled explicitly rather than relying on v6 having narrowed auto-detection to npm. docker/login-action is also still node20 and would have warned on the next release run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every Actions run is annotated with
Node.js 20 is deprecated— runners forcenode20actions onto Node 24 today, but the runtime is being retired.checkout(v6) andcache(v5) were already current;setup-node,upload-artifact,download-artifactanddocker/login-actionwere not.What Changed
actions/setup-node: v4 → v7 (v5 is the firstnode24release)actions/upload-artifact: v4 → v7 (v5 was preliminary node24 and still defaulted to node20; v6 is the first real fix)actions/download-artifact: v4 → v8 (same — v6 preliminary, v7 is the real fix)docker/login-action: v3 → v4 (still node20; only runs inrelease.yml, so it would have warned on the next release)setup-pnpm*composites: addedpackage-manager-cache: false—setup-nodev5+ auto-caches whenpackage.jsondeclares apackageManager(pnpm here), but these composites runsetup-nodebefore pnpm is installed and already cache the store viaactions/cacheHow to Test
CI on this PR should run clean with no Node 20 annotations.
release.ymlis only exercised on tag push.Notes