Repository navigation
iPad 7: scale the 1620×2160 panel - #41
Merged
Merged
Conversation
The scale script accepted only the iPad 6 modes, so a 1620x2160 iPad 7 stayed at scale 1. Accept that panel in both orientations and set scale 2, which is what is in use on one J171.
Both sides added a line at the top of the Desktop list in the changelog; keep both.
Contributor
|
Thanks @jerricky26 , do you have an X handle? |
Contributor
Author
|
Yes I most certainly do! X is the global town square and de facto free speech platform. Everyone should have an X account! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scale script accepts the iPad 6 modes,
1536x2048and2048x1536. On this iPad 7 Wi-Fi the panel is1620x2160at 60 Hz, so login left the scale at 1 and the desktop was too small to use. Adding1620x2160and2160x1620makes that same script set scale 2. Scale 2 is what is running on this J171.2160x1620is the same panel in landscape, so a rotation still matches. iPad 6 modes are unchanged.