Repository navigation
Conversation
The A9 AOP driver on main reads apple,aop-target, apple,chip-id and apple,chip-revision, and the motion sensor drivers read their factory calibration, from properties the bootloader fills in. Nothing on main fills them in; going by the driver's probe, the A9 AOP cannot start without them (read from the code, not run). This is the m1n1 patch that fills them in, from OrchardLinux#101, unchanged. Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The A9 AOP driver on main reads
apple,aop-target,apple,chip-idandapple,chip-revisionfrom the device tree, and the motion sensor drivers read their factory calibration from properties of the same kind. iBoot puts these values in the ADT, but nothing on main copies them into the FDT. Going by the driver's probe, the A9 AOP (and with it the accelerometer, gyroscope and pressure sensor) cannot start without them. This is read from the code; main's AOP path has not been run on an A9 without this patch.Changes
One m1n1 patch,
0021-kboot-Pass-the-A9-AOP-s-boot-arguments-and-sensor-ca.patch:aop-target(fromiop-aop-nub),chip-id(from/chosen) andchip-revision(from/arm-io) into the AOP node asapple,…properties;iop-aop-nubinto the sensor child node of the same name, with anapple,prefix. Calibration that iBoot left as an unresolvedsyscfg/reference is skipped.It is the m1n1 patch from #101, unchanged. #101 landed only the kernel side.
Testing
c9ef56f.Numbering
The file keeps the number
0021that it has in #107, which carries the identical file. Whichever of the two lands first, the other merges cleanly, and the next update of #107 drops its copy. Until #107 lands,0015–0020are unused on main; the patches still apply in order.🤖 Generated with Claude Code