Repository navigation
Run dpplint with two replicas and 16 threads each - #27
Merged
Merged
Conversation
Two replicas with RAILS_MAX_THREADS=16 let 32 checks run at the same time, so a few checks against a host that does not answer no longer hold up the service. Rolling updates keep both replicas available (maxUnavailable 0). A replica whose threads are all busy fails its readiness probe (/version, every 5 s with a 2 s timeout, after two failures) and is taken out of the ingress until it answers again. The liveness probe now only checks that the port is open, so a busy replica is not restarted. The memory request follows what 16 parallel checks use (about 480 MiB measured); the limit stays at 1 GiB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With one replica and 3 threads, three checks against a passport host that does not answer kept the service busy for up to 35 s:
/upand every other request waited until they ended.RAILS_MAX_THREADS=16): up to 32 checks run at the same time. Rolling updates start the new replica before the old one stops (maxUnavailable: 0,maxSurge: 1)./version, every 5 s, 2 s timeout, out after two failures): a replica whose threads are all busy is taken out of the ingress until it answers again.Tests
kubeconform -strictagainst Kubernetes 1.30: deployment, service and ingress valid./versionwith a 2 s timeout failed until the checks ended (34.7 s); a TCP connection to the port succeeded on every one of 45 probes.