Repository navigation
Build with dpp-criteria 9655c4c; test DPP-CAR-002 v2 and DPP-REG-024 - #29
Merged
Merged
Conversation
- The image is built with dpp-criteria 9655c4c. DPP-CAR-002 version 2 gives a warning for a GTIN with the GS1 prefix 952, which GS1 uses for demonstrations and examples; DPP-REG-024 checks that the unique product identifier is an https URL of at most 2000 characters. - Integration tests: the prefix 952 gives the warning, other prefixes do not (also 952 after the indicator digit 9); DPP-REG-024 passes for the reference passport and fails for a DID and for 2001 characters. - kubernetes/deployment.yaml names the digest of the new image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds dpplint with dpp-criteria
9655c4c(OwnYourData/dpp-criteria#36) and tests the two changed passport checks. No change to the application code: the checks are SHACL shapes of the SOyA structureDigitalProductPassport, which the image takes from dpp-criteria.Checks in this build
https://URL of at most 2000 characters, the form in which the EU DPP registry accepts it.Both are
proposedand do not count in "N of M". The reference passports of the OwnYourData DPP Service use the prefix 952 and get the DPP-CAR-002 warning on purpose.Changes
test/integration/validations_test.rb: three integration tests against the structures in the image.kubernetes/deployment.yaml: digest of the new image, written byDOCKERHUB=1 ./build.sh.Tests
docker run --rm --platform linux/amd64 oydeu/dpplint:latest test: 256 runs, 0 failures. Against the previous criteria, two of the three new tests fail, as expected.