Repository navigation
Build with dpp-criteria bb02a5e; test the new passport criteria - #30
Merged
Merged
Conversation
- The image is built with dpp-criteria bb02a5e: DPP-DAT-026 (XSD types that EN 18223 excludes), DPP-ID-015 (ISO/IEC 646 characters and RFC 3986 syntax of the identifiers), DPP-ID-054 (DID methods of product DIDs) and DPP-SEC-020 (no cookie on public reads), all proposed. - Integration tests: an excluded XSD type fails DPP-DAT-026; a non-ASCII character or a space in a URI fails DPP-ID-015, a percent-encoded identifier passes; a product DID with another method gives a DPP-ID-054 warning, did:web passes, an https identifier is skipped; DPP-SEC-020 needs a product identifier. - kubernetes/deployment.yaml names the digest of the new image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds dpplint with dpp-criteria
bb02a5e(OwnYourData/dpp-criteria#37) and tests the new passport criteria. No change to the application code: three criteria are SHACL shapes of the SOyA structureDigitalProductPassport, one is aresolvecheck, and the image takes all of them from dpp-criteria.Checks in this build
All new criteria are
proposedand do not count in "N of M".The catalogue references of other criteria changed as well; their checks are unchanged.
Changes
test/integration/validations_test.rb: three integration tests for DPP-DAT-026, DPP-ID-015 and DPP-ID-054; DPP-SEC-020 joins the checks that need a product identifier.kubernetes/deployment.yaml: digest of the new image, written byDOCKERHUB=1 ./build.sh.Tests
docker run --rm --platform linux/amd64 oydeu/dpplint:latest test: 259 runs, 0 failures. Against the previous criteria, the four new or changed tests fail, as expected.