Repository navigation
Check the HTML view with the Nu Html Checker in the same pod - #32
Merged
Merged
Conversation
html with markup_errors: forbidden (DPP-DAT-020) posts the HTML view, as received and with its media type and charset, to the Nu Html Checker at NU_CHECKER_URL and fails on every message of type error; warnings and other info messages do not count. Without a checker, or if it does not answer or cannot check the document, the criterion is skipped. The deployment runs the checker (ghcr.io/validator/validator, named by its digest) as a second container of each pod. It listens on 127.0.0.1 only and runs with a heap of 192 MB within a memory limit of 512 Mi; the readiness of the pod does not depend on it. Test vectors for DPP-DAT-020 with the recorded answers of the checker are under test/fixtures/files/html/DPP-DAT-020. The image is built with the dpp-criteria commit that adds the criterion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the new passport criterion DPP-DAT-020 of dpp-criteria (
proposed): the HTML view conforms to the HTML standard, as far as the Nu Html Checker can tell.htmlwithmarkup_errors: forbiddenNU_CHECKER_URL(NuChecker). It never sends the document to a public instance.errorfails the criterion; the message names up to 10 errors with their line. Warnings and otherinfomessages do not count.not_evaluated): withoutNU_CHECKER_URL, if the checker does not answer, answers with an error page or invalid JSON, or reports that it could not check the document (non-document-error). The request keeps within the time limit of the check.Deployment
ghcr.io/validator/validator, MIT licence, version 26.10.12) as a second container, named by its digest.Test vectors
test/fixtures/files/html/DPP-DAT-020/)The answers of the checker to the vectors are recorded next to them; the tests answer with them through a local server instead of running the checker. The README in that directory shows how to record them again.
Further tests cover the request to the checker, the messages, the cut after 10 errors, the cases without a usable checker, and the time limit.
SlowServernow also reads a request body.Both reference passports have no error in the checker.
The image is built with the dpp-criteria commit that adds the criterion.
kubernetes/deployment.yamlnames its digest.