Repository navigation
Conversation
The image is built with the dpp-criteria commit in which the warning of DPP-CAR-002 says that the GTIN carries the GS1 prefix 952 and the prefix is also found in a GTIN-8. The integration test checks the wording of the warning and a GTIN-8 padded to 14 digits. The README says how often the digest of the Nu Html Checker is compared with the latest release and how the checker is updated: new digest in the manifest, the answers to the test vectors recorded again, the example passports checked with the new checker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPP-CAR-002 version 3
The image is built with the dpp-criteria commit that brings DPP-CAR-002 version 3:
dpplint itself does not change. The integration test now checks the wording of the warning and adds a GTIN-8 padded to 14 digits.
Updating the Nu Html Checker
The README, section "Deployment", now says:
How often: the digest of the checker is compared with the latest release once a month, and at once when a security notice concerns the checker or its image.
How:
The dpplint image does not change for this.
kubernetes/deployment.yamlnames the digest of the new dpplint image.