Repository navigation
Set the Google Ads conversion ID of the start page - #37
Merged
Merged
Conversation
GOOGLE_ADS_ID is AW-894120911, so the start page shows the consent banner and, after consent, measures a completed check. The privacy policy of the DPP services now describes this conversion. The image is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
GOOGLE_ADS_IDtoAW-894120911inkubernetes/deployment.yaml. The label of the conversion and the image stay as they are.With the ID set, the start page shows the consent banner. Only after "Accept" does it load the Google Ads tag and send one conversion per completed check, without the product identifier and without the result. Without consent nothing is requested from Google. The privacy policy of the DPP services, https://dpp-service.ownyourdata.eu/privacy, describes this conversion in "Conversion tracking with Google Ads".
The behaviour with an ID is covered by
test/integration/consent_test.rband checked in a browser withtest/browser/consent_check.mjs.