Repository navigation
Conversation
lsConsole.runFinished() called self.finishedCallback() with no arguments, but both real callers (_update_finished and myCallback in plugin.py) declare it as finishedCallback(self, result=None) and branch on that result to decide success vs failure. Since it was never passed anything, result was always None (falsy), so _update_finished always took the "Update failed!" branch regardless of the actual outcome - even though the wget|sh install/update itself had completed fine. Pass the same success flag already computed for self.callback (not self.errorOcurred), matching the line right above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsConsole.runFinished() called self.finishedCallback() with no arguments, but both real callers (_update_finished and myCallback in plugin.py) declare it as finishedCallback(self, result=None) and branch on that result to decide success vs failure. Since it was never passed anything, result was always None (falsy), so _update_finished always took the "Update failed!" branch regardless of the actual outcome - even though the wget|sh install/update itself had completed fine.
Pass the same success flag already computed for self.callback (not self.errorOcurred), matching the line right above it.