Import existing TW WAF rules - #909
Open
farski wants to merge 3 commits into
Open
Conversation
kookster
approved these changes
Jul 30, 2026
kookster
left a comment
Member
There was a problem hiding this comment.
It seems good to me: I agree we'll need to try it to see how it does
| - SG | ||
| - BR | ||
| - HK | ||
| - MY |
Member
There was a problem hiding this comment.
These change at times, but we have had rules for them for awhile, so I agree, best to default back to them
| Statement: | ||
| RegexPatternSetReferenceStatement: | ||
| # TODO Sort out multi-region | ||
| Arn: arn:aws:wafv2:us-east-1:976680550710:global/regexpatternset/BadBots/77983be8-c291-4263-97fc-08424eaee286 |
Member
There was a problem hiding this comment.
It's not automatic, so probably fine - can look up the regex list value in west if we wanted to
| ManagedRuleGroupStatement: | ||
| VendorName: AWS | ||
| Name: AWSManagedRulesBotControlRuleSet | ||
| Version: Version_6.0 |
Member
There was a problem hiding this comment.
OT: I didn't find much info about what versions are better or worse for this?
| MetricName: BadBots | ||
| Action: | ||
| Block: {} | ||
| - Name: AdminKnownGeosOnly |
Member
There was a problem hiding this comment.
really nice to have this rule, and restore it when this runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There aren't a lot of examples about how Console configuration maps to CFN config, so some of this was a guess. We probably just have to see what the results are in staging.
Closes https://github.com/PRX/internal/issues/1493