Skip to content

Import existing TW WAF rules - #909

Open
farski wants to merge 3 commits into
mainfrom
tw-waf-rules
Open

Import existing TW WAF rules#909
farski wants to merge 3 commits into
mainfrom
tw-waf-rules

Conversation

@farski

@farski farski commented Jun 26, 2026

Copy link
Copy Markdown
Member

There aren't a lot of examples about how Console configuration maps to CFN config, so some of this was a guess. We probably just have to see what the results are in staging.

Closes https://github.com/PRX/internal/issues/1493

@farski
farski requested a review from kookster June 26, 2026 14:07

@kookster kookster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me: I agree we'll need to try it to see how it does

- SG
- BR
- HK
- MY

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These change at times, but we have had rules for them for awhile, so I agree, best to default back to them

Statement:
RegexPatternSetReferenceStatement:
# TODO Sort out multi-region
Arn: arn:aws:wafv2:us-east-1:976680550710:global/regexpatternset/BadBots/77983be8-c291-4263-97fc-08424eaee286

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not automatic, so probably fine - can look up the regex list value in west if we wanted to

ManagedRuleGroupStatement:
VendorName: AWS
Name: AWSManagedRulesBotControlRuleSet
Version: Version_6.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT: I didn't find much info about what versions are better or worse for this?

MetricName: BadBots
Action:
Block: {}
- Name: AdminKnownGeosOnly

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice to have this rule, and restore it when this runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants