Skip to content

⚙️ [Maintenance]: Lock Pester test dependency to the 6.x major version#23

Open
Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
mainfrom
maintenance/lock-pester-major-6
Open

⚙️ [Maintenance]: Lock Pester test dependency to the 6.x major version#23
Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
mainfrom
maintenance/lock-pester-major-6

Conversation

@MariusStorhaug

@MariusStorhaug Marius Storhaug (MariusStorhaug) commented Jul 7, 2026

Copy link
Copy Markdown
Member

This module's Pester tests now lock to the 6.x major version instead of the exact 5.8.0 pin. An exact pin breaks whenever the runner resolves a different Pester (as happened once 5.8.0 was superseded); a major lock tracks every 6.x release while still blocking an unvetted new major.

Changed: the exact 5.8.0 pin becomes a 6.x major lock

Each *.Tests.ps1 file now requires:

#Requires -Modules @{ ModuleName = 'Pester'; ModuleVersion = '6.0.0'; MaximumVersion = '6.*' }

Any Pester 6.x satisfies it, so routine minor and patch updates no longer need a PR — only a new major does.

Technical Details

Copilot AI review requested due to automatic review settings July 7, 2026 14:39
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

No Significant Changes Detected

This PR does not contain changes to files that would trigger a new release:

Pattern Description
^src/ Matches files where path matches this pattern
^README\.md$ Matches files where path matches this pattern

Build, test, and publish stages will be skipped for this PR.

If you believe this is incorrect, please verify that your changes are in the correct locations.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITLEAKS Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
MARKDOWN Pass ✅
NATURAL_LANGUAGE Pass ✅
POWERSHELL Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test suite’s PowerShell #Requires -Modules directive to require Pester 6.x (minimum 6.0.0, maximum 6.999.999) instead of an exact 5.8.0 pin, aligning test execution with the newly published major version while still preventing silent adoption of a future Pester 7.x major.

Changes:

  • Replaced RequiredVersion = '5.8.0' with a ModuleVersion + MaximumVersion range to allow any Pester 6.x.
  • Kept the Pester module GUID pin to enforce module identity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/Json.Tests.ps1 Outdated
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

No Significant Changes Detected

This PR does not contain changes to files that would trigger a new release:

Pattern Description
^src/ Matches files where path matches this pattern
^README\.md$ Matches files where path matches this pattern

Build, test, and publish stages will be skipped for this PR.

If you believe this is incorrect, please verify that your changes are in the correct locations.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITLEAKS Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
MARKDOWN Pass ✅
NATURAL_LANGUAGE Pass ✅
POWERSHELL Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

The GUID pins module identity (precise pinning), a stricter control than the lock-to-major risk appetite. Keep only the version range.
Copilot AI review requested due to automatic review settings July 7, 2026 19:10
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

No Significant Changes Detected

This PR does not contain changes to files that would trigger a new release:

Pattern Description
^src/ Matches files where path matches this pattern
^README\.md$ Matches files where path matches this pattern

Build, test, and publish stages will be skipped for this PR.

If you believe this is incorrect, please verify that your changes are in the correct locations.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread tests/Json.Tests.ps1
Comment thread tests/Json.Tests.ps1
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITLEAKS Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
MARKDOWN Pass ✅
NATURAL_LANGUAGE Pass ✅
POWERSHELL Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants