fix(e2e): fix Settings heading and WebKit SSO redirect failures - #522
Merged
Merged
Conversation
… to "Workspace Settings"
Contributor
|
This run was cancelled 🛑 The workflow was cancelled before completion. Please check the link below for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes the Playwright failures in E2E run 36327807787, which failed on all 5 browser jobs.
1. Settings spec: heading renamed (all browsers)
The SSO work (8799c12) renamed the Settings page heading from "Workspace Branding" to "Workspace Settings".
settings.spec.tsandsettings.featurestill looked for the old heading, so 9 tests failed on every browser. This PR updates them to use "Workspace Settings".2. SSO spec: WebKit rejects a fulfilled 302 (webkit, mobile-safari)
A first-time user gets a new accountfailed with:routeMockProviderintercepts Paca's SSO login redirect and rewrites itsLocationto the mock provider's public port. WebKit won't let a test answer a page load with a redirect status. The route now answers 200 with a<meta http-equiv="refresh">page that forwards to the rewritten URL. It still sends the original headers, includingSet-Cookie: sso_state, so the sign-in stays tied to the same browser. This works in every browser.Test plan
settings.spec.ts+sso.spec.tspass locally on chromium (18/18)Not in scope
Four tests failed once and passed on retry in that run, so they're flaky rather than broken:
conversations.spec.ts:979(chromium)changelog.spec.ts:197(mobile-safari)docs.spec.ts:350(mobile-safari)management.spec.ts:291(mobile-safari)They didn't fail any job, and this PR doesn't change them.
🤖 Generated with Claude Code