Resourcepack callbacks - #1892
Open
WouterGritter wants to merge 3 commits into
Open
WouterGritter wants to merge 3 commits into
WouterGritter wants to merge 3 commits into
Conversation
Squashed from #1809.
- Keep callbacks on clearAppliedResourcePacks, so pending packs still get their terminal status - Run callbacks in order on Velocity's executor instead of the common pool - Fire the status event independently of the callback - Log the callback class on failure - Note that noOp() is a singleton
R00tB33rMan
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1369. Adventure
ResourcePackCallbacks passed throughPlayer#sendResourcePacks(ResourcePackRequest)were never called.Based on #1809, which was closed after its branch was deleted, and GemstoneGG#924 (the same change), plus these fixes:
ConcurrentHashMapand every resource pack response threw an NPE. Callbacks are now looked up by the queued pack's ID.clearAppliedResourcePacks()wiped them, so packs still pending during a 1.20.2 server switch, a backend clear, orPlayer#clearResourcePacksnever got their terminal status. Callbacks are now only removed when a pack reaches a terminal status.ACCEPTED,DOWNLOADEDandSUCCESSFULcallbacks could run in any order. They now run in order for each player, on Velocity's executor.PlayerResourcePackStatusEventand the force-pack kick. Both now fire independently.Adds
PlayerResourcePackStatusEvent.Status#adventureStatus()to the API.