Repository navigation
feat(db): columns for the workspace drive (migrations only, split from #9847) - #9915
Draft
saddlepaddle wants to merge 1 commit into
Draft
saddlepaddle wants to merge 1 commit into
saddlepaddle wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Preview update published for development build |
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
10 tasks
saddlepaddle
force-pushed
the
superset/workspace-drive-columns
branch
from
November 18, 2026 03:01
99b0fd8 to
8bec0b7
Compare
saddlepaddle
force-pushed
the
superset/workspace-drive-columns
branch
from
November 18, 2026 03:14
8bec0b7 to
7b454fc
Compare
saddlepaddle
had a problem deploying
to
preview
November 18, 2026 03:14 — with
GitHub Actions
Failure
Adds three nullable columns, no defaults, nothing reads them yet: - environments.golden_drive_name: the Vercel drive an environment's workspace drives fork from. - cloud_workspaces.drive_name: the drive mounted on every session of a workspace's box. - cloud_workspaces.drive_laid_out_at: when a boot first answered with the drive laid out. One migration, 0199, generated by drizzle-kit on main after 0198. Split from #9847 so the migration lands before the code that uses it.
saddlepaddle
force-pushed
the
superset/workspace-drive-columns
branch
from
November 18, 2026 21:44
7b454fc to
78a831b
Compare
saddlepaddle
had a problem deploying
to
preview
November 18, 2026 21:44 — with
GitHub Actions
Failure
saddlepaddle
added a commit
that referenced
this pull request
Nov 18, 2026
The workspace drive work of #9847 as one commit on main after 78a831b (#9915, migration 0199), resolved by hand against main's M5b failure reasons, M7s logging, M8 metering, M9 non-resuming handles, and the agent-tools drive. The previous 33 commits are kept locally as backup/9847-pre-rebase. Merged with main: - wakeSandbox keeps the resume lock, the drive detach, the composed mounts and withLiveSession, and takes main's onlyIfRunning and its non-resuming handles; a session withLiveSession resumes mid-wake is reported to beforeResume as resumedSession before it boots, so it is metered as M9 meters it. - promoteSandboxToEnvironment takes main's shape: the snapshot ends the source's session and the caller's wakeAfterStop starts it again; the drive fork and the golden drive's strip stay. - provision fails through failCloudWorkspace, which now takes onBox and answers whether it moved the row, so a provision still fails only its own row. - A delete or a failed create still retires the names (retireAndTearDown).
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrations and schema only, split out of #9847 so they land before the code that reads them (
packages/trpc/AGENTS.mdrule 10). Draft until the coordinator says so.What changed
0199_workspace_drive:cloud_workspaces.drive_name text,cloud_workspaces.drive_laid_out_at timestamptz,environments.golden_drive_name text.packages/db/src/schema/schema.ts.All three are nullable, with no default and no index. Nothing on main reads or writes them, so there is no tRPC input or output change. On 2026-11-18 main gained its own
0197and0198. So the branch was rebuilt on main (e0f54fa): only the schema change was applied, anddrizzle-kit generatewrote the migration as0199on top of main's journal. The SQL is the same three statements as before. Nothing underpackages/db/drizzle/was hand-edited.Safety checklist (
.agents/skills/db-migrations/SKILL.md)cloud_workspaces9,680 kB (~6,649 rows),environments232 kB (~258 rows).ADD COLUMNwith no default is a catalog-only change; the lock is held for a moment.Checks
drizzle-kit migrateon a new Neon dev branch made from production on 2026-11-18 (dev/workspace-drive-0199, br-soft-frog-afohxaia), withlock_timeout=5sandstatement_timeout=60s. It was at 0198 before and applied 0199; the three columns exist with the expected types.biome checkon the schema file passed.Summary by cubic
Adds three nullable DB columns for the workspace drive as a migrations-only PR, split from #9847 so they land before the code that reads them.
environments.golden_drive_nameandcloud_workspaces.drive_name(text), pluscloud_workspaces.drive_laid_out_at(timestamptz).ALTER TABLEs are catalog-only, so they hold no long locks and don't change existing behavior.Written for commit 78a831b. Summary will update on new commits.