-
Notifications
You must be signed in to change notification settings - Fork 51
Add custom checks stores & storage checks #5668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rbev
wants to merge
8
commits into
master
Choose a base branch
from
rhys/sql-customchecks2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8b18c8d
Add custom checks shared implementation
rbev 9b351a4
Add storage checks for sql server
rbev 6193e00
Add postgres disk space checks
rbev 3a8ebe8
use valid value for rollforward
rbev 221c6b8
Revert custom checks for database space
rbev f9804f5
Add db migrations
rbev e108d56
fix formatting
rbev b32bae0
Remove unused usings
rbev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "10.0.100", | ||
| "version": "10.0.302", | ||
| "allowPrerelease": false, | ||
| "rollForward": "latestFeature" | ||
| "rollForward": "disable" | ||
| }, | ||
| "msbuild-sdks": { | ||
| "Microsoft.Build.NoTargets": "3.7.134" | ||
| } | ||
| } | ||
| } | ||
481 changes: 481 additions & 0 deletions
481
...ntrol.Persistence.EFCore.PostgreSql/Migrations/20260731054116_AddCustomChecks.Designer.cs
Large diffs are not rendered by default.
Oops, something went wrong.
41 changes: 41 additions & 0 deletions
41
...ServiceControl.Persistence.EFCore.PostgreSql/Migrations/20260731054116_AddCustomChecks.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| using System; | ||
| using Microsoft.EntityFrameworkCore.Migrations; | ||
|
|
||
| #nullable disable | ||
|
|
||
| namespace ServiceControl.Persistence.EFCore.PostgreSql.Migrations | ||
| { | ||
| /// <inheritdoc /> | ||
| public partial class AddCustomChecks : Migration | ||
| { | ||
| /// <inheritdoc /> | ||
| protected override void Up(MigrationBuilder migrationBuilder) | ||
| { | ||
| migrationBuilder.CreateTable( | ||
| name: "custom_checks", | ||
| columns: table => new | ||
| { | ||
| id = table.Column<Guid>(type: "uuid", nullable: false), | ||
| custom_check_id = table.Column<string>(type: "text", nullable: false), | ||
| category = table.Column<string>(type: "text", nullable: false), | ||
| status = table.Column<int>(type: "integer", nullable: false), | ||
| reported_at = table.Column<DateTime>(type: "timestamp with time zone", nullable: false), | ||
| failure_reason = table.Column<string>(type: "text", nullable: true), | ||
| originating_endpoint_name = table.Column<string>(type: "text", nullable: false), | ||
| originating_endpoint_host_id = table.Column<Guid>(type: "uuid", nullable: false), | ||
| originating_endpoint_host = table.Column<string>(type: "text", nullable: false) | ||
| }, | ||
| constraints: table => | ||
| { | ||
| table.PrimaryKey("pk_custom_checks", x => x.id); | ||
| }); | ||
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| protected override void Down(MigrationBuilder migrationBuilder) | ||
| { | ||
| migrationBuilder.DropTable( | ||
| name: "custom_checks"); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do this without talking to Brandon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or at least do it in a different PR so we can bring him in for a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sorry, had just done it on this branch to test and forgot to revert it