Better naming of methods - #5681
Open
johnsimons wants to merge 1 commit into
Open
Conversation
The two by-id lookups differed only in that one reads unresolved groups and the other archived ones, which neither the names nor the signatures showed. The four status-scoped members are now named after what they return: GetUnresolvedGroupsByClassifier, GetArchivedGroupsByClassifier, GetUnresolvedGroup and GetArchivedGroup. GetUnresolvedGroup returns a single view like its archived twin, so neither controller picks the first result off a list any more. GetCurrentForwardingBatch moves to IRetryDocumentDataStore, where the NowForwarding pointer it reads already lives. QueryFailureGroupViewOnGroupId is deleted because it ran the same query as GetUnresolvedGroup, so RetryAllInGroupHandler calls that instead. Both group-by-id endpoints now return 404 for an unknown group instead of an empty 204, matching GetErrorByIdController. ServicePulse reads these only to label a group, and its client already fails on the empty 204, so this gives it a status it can actually handle.
johnsimons
force-pushed
the
john/refactors_renames
branch
from
July 31, 2026 23:43
425a657 to
44043cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two by-id lookups differed only in that one reads unresolved groups and the other archived ones, which neither the names nor the signatures showed.
The four status-scoped members are now named after what they return: GetUnresolvedGroupsByClassifier, GetArchivedGroupsByClassifier, GetUnresolvedGroup and GetArchivedGroup.
GetUnresolvedGroup returns a single view like its archived twin, so neither controller picks the first result off a list any more.
GetCurrentForwardingBatch moves to IRetryDocumentDataStore, where the NowForwarding pointer it reads already lives. QueryFailureGroupViewOnGroupId is deleted because it ran the same query as GetUnresolvedGroup, so RetryAllInGroupHandler calls that instead.
Both group-by-id endpoints now return 404 for an unknown group instead of an empty 204, matching GetErrorByIdController. ServicePulse reads these only to label a group, and its client already fails on the empty 204, so this gives it a status it can actually handle.