Skip to content

Fix gem group counting logic#2292

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
moxaj:fix-skill-group-count
Jul 11, 2026
Merged

Fix gem group counting logic#2292
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
moxaj:fix-skill-group-count

Conversation

@moxaj

@moxaj moxaj commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Before, when you had a granted skill from an item / tree, and disabled that socket group, it would be counted towards the limit of 9.

Steps taken to verify a working solution:

  • equip 9 Arc gems, each in its own group
  • equip Sadist's Mercy Flanged Mace
  • disable the granted Harbinger of Madness
  • verify that there is no warning message for going over the limit of 9
  • add another socket group with Arc and Ice Nova (in the same group)
  • verify that there's a warning for the limit iff the socket group is enabled and at least one of Arc and Ice Nova is enabled

@LocalIdentity LocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified the fix

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Jul 11, 2026
@LocalIdentity LocalIdentity merged commit 4059151 into PathOfBuildingCommunity:dev Jul 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants