fix(runtime): preserve URL state in subclasses - #11090
proggeramlug wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on Cherry-picked from this PR's head Nothing needed from you. Thanks. |
Summary
URLsubclasses through the branded builtin constructor pathinstanceof URLlowering about branded and recorded-prototype URL instancesFixes #10639
Root cause
URLwas absent from the exotic builtin constructor lists used by implicit derived constructors and explicitsuper(...)calls. The explicit path also classifiedURLas a runtime-valued parent, so it could be invoked through the plain call path instead of the builtin construct path. Instances kept their subclass shape but never received URL state.Validation
test_gap_10639_url_subclass: 1/1 passed, 100% paritycargo build --profile perry-dev -p perry -p perry-runtime-static -p perry-stdlib-staticcargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh