Skip to content

fix(ci): track moved RS4GC unit gate - #9930

Closed
proggeramlug wants to merge 1 commit into
PerryTS:mainfrom
proggeramlug:fix/9928-llvm-inprocess-test-path
Closed

fix(ci): track moved RS4GC unit gate#9930
proggeramlug wants to merge 1 commit into
PerryTS:mainfrom
proggeramlug:fix/9928-llvm-inprocess-test-path

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

The scheduled llvm-inprocess run passed its full codegen test suite but failed afterward because its non-vacuity assertion still expected inprocess::tests::rs4gc_schedules_in_process. The inprocess.rs split moved that test to inprocess::optimize_emit::tests, so the gate reported failure even though the RS4GC pin ran and passed.

Match the unique test-function suffix instead of its internal module path, and remove the stale hard-coded suite count from the step label. The assertion still requires an explicit ... rs4gc_schedules_in_process ... ok harness line, so a skipped or missing test cannot make the gate green.

Validation:

  • exact workflow unit block: 1,449 passed, 1 ignored, 0 failed; all four corpus/RS4GC non-vacuity assertions matched;
  • actionlint .github/workflows/llvm-inprocess.yml;
  • scripts/run_lint_gates.sh: all 64 local gates passed, 2 CI-expression rows skipped; workspace warnings check and Clippy passed.

Closes #9928

Summary by CodeRabbit

  • Chores
    • Improved automated validation for in-process test results.
    • Test checks now support valid executions across different in-process module paths.
    • Test reporting no longer depends on a hardcoded total test count.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 5ede6bd4-a9e2-420c-8e37-981ad96293b3

📥 Commits

Reviewing files that changed from the base of the PR and between 87dc334 and 3622fcd.

📒 Files selected for processing (1)
  • .github/workflows/llvm-inprocess.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The workflow removes the hardcoded unit-test count from the gate name. It also replaces the fixed RS4GC test path match with an anchored regex that accepts any submodule path.

Changes

LLVM in-process gate

Layer / File(s) Summary
Workflow gate naming and assertion
.github/workflows/llvm-inprocess.yml
The unit-gates label no longer includes a fixed test count. The RS4GC assertion matches the test output under any submodule and anchors the complete line.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 3622f

The scheduled LLVM in-process gate now recognizes the relocated RS4GC test while still requiring it to pass. The stale test-count label is removed, and the workflow change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the CI fix for the relocated RS4GC unit gate.
Description check ✅ Passed The description explains the failure, the workflow changes, the validation performed, and links issue #9928. It omits the template headings and checklist, but the required content is substantially pre…
Linked Issues check ✅ Passed The changes address issue #9928 by updating the llvm-inprocess gate to detect the relocated rs4gc_schedules_in_process test and removing the stale test-count label.
Out of Scope Changes check ✅ Passed The changes are limited to the llvm-inprocess workflow and directly support the linked issue. No unrelated changes are identified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug

Copy link
Copy Markdown
Contributor Author

Landed on main via merge train #9939. Validated as a tree: 66/66 lint gates, and perry-runtime/codegen/hir/stdlib all green (5,966 tests, 0 failures). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scheduled-gate:llvm-inprocess.yml] llvm-inprocess is failing on main

1 participant