fix(ci): track moved RS4GC unit gate - #9930
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe workflow removes the hardcoded unit-test count from the gate name. It also replaces the fixed RS4GC test path match with an anchored regex that accepts any submodule path. ChangesLLVM in-process gate
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The scheduled LLVM in-process gate now recognizes the relocated RS4GC test while still requiring it to pass. The stale test-count label is removed, and the workflow change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on |
The scheduled
llvm-inprocessrun passed its full codegen test suite but failed afterward because its non-vacuity assertion still expectedinprocess::tests::rs4gc_schedules_in_process. Theinprocess.rssplit moved that test toinprocess::optimize_emit::tests, so the gate reported failure even though the RS4GC pin ran and passed.Match the unique test-function suffix instead of its internal module path, and remove the stale hard-coded suite count from the step label. The assertion still requires an explicit
... rs4gc_schedules_in_process ... okharness line, so a skipped or missing test cannot make the gate green.Validation:
actionlint .github/workflows/llvm-inprocess.yml;scripts/run_lint_gates.sh: all 64 local gates passed, 2 CI-expression rows skipped; workspace warnings check and Clippy passed.Closes #9928
Summary by CodeRabbit