Skip to content

Keep the content URI when the picked file's path is not writable #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cheblin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Keep the content URI when the picked file's path is not writable #3319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/keepass2android-app/Utils/Util.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,9 @@ public static string IntentToFilename(Intent data, Context ctx)
c1.MoveToFirst();

var possibleFilename = c1.GetString(0);
if (File.Exists(possibleFilename))
//the path only if it may be written: on Android 11+ a file of the shared storage is readable by its path but not
//writable (pickers like the one of HyperOS give the path too), while the content uri itself grants writing
if (File.Exists(possibleFilename) && new Java.IO.File(possibleFilename).CanWrite())
return possibleFilename;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/keepass2android-app/fileselect/FileSelectActivity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ protected override void OnActivityResult(int requestCode, Result resultCode, Int

if ((resultCode == Result.Ok) && (requestCode == RequestCodeEditIoc))
{
string filename = Util.IntentToFilename(data, this);
string filename = Util.IntentToFilename(data, this) ?? data.DataString;

LaunchPasswordActivityForIoc(IOConnectionInfo.FromPath(filename));
}
Expand Down