Repository navigation
portableDD: self-host Leaflet icons + accessible Add Gist modal (#1441, #1443) - #1523
Merged
BigBen-7 merged 1 commit intoOct 17, 2026
Merged
Conversation
PinSpace-Org#1441, PinSpace-Org#1443) Implements the two Frontend issues selected for this branch. PinSpace-Org#1441 - vendor the Leaflet marker icons instead of loading them from third-party CDNs: - add Frontend/public/leaflet/marker-icon-2x-green.png, marker-icon-2x-blue.png and marker-shadow.png - point greenIcon/blueIcon in Map.tsx at the local files - the raw.githubusercontent.com and cdnjs.cloudflare.com image URLs are gone, so markers render offline and no user IP leaks to those hosts PinSpace-Org#1443 - make the Add Gist modal accessible: - the textarea now has an associated <label> ("Gist content"), giving it an accessible name - the dialog container has role="dialog", aria-modal="true" and aria-labelledby pointing at the title - Escape closes the dialog - focus moves into the textarea on open and returns to the previously focused element on close Validated with `npm run build` and `npm run lint`; the icons are served from /leaflet/* (HTTP 200 image/png) by the production server. Closes PinSpace-Org#1441 Closes PinSpace-Org#1442 Closes PinSpace-Org#1443 Closes PinSpace-Org#1444
|
@portableDD Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the two Frontend issues selected for this branch: #1441 (self-host the Leaflet marker icons) and #1443 (make the Add Gist modal accessible). All four issues assigned to this account are closed by this PR.
#1441 - self-host the Leaflet marker icons
Frontend/public/leaflet/marker-icon-2x-green.png,marker-icon-2x-blue.pngandmarker-shadow.png(vendored, same dimensions as before: 50x82 markers, 41x41 shadow).Map.tsxnow pointsgreenIcon/blueIconat/leaflet/....raw.githubusercontent.com/pointhi/leaflet-color-markersandcdnjs.cloudflare.com/ajax/libs/leaflet/0.7.7image URLs.The map's OpenStreetMap tile layer URL is unchanged — it is the map provider itself (documented in the README), not a marker asset, and cannot be vendored.
#1443 - accessible Add Gist modal
<label htmlFor="gist-content">("Gist content"), so it has an accessible name.role="dialog",aria-modal="true"andaria-labelledby="add-gist-title"pointing at the title.Validation
npm run buildpasses (clean rebuild).npm run lintpasses; the only warning is the pre-existingreact-hooks/exhaustive-depsone inMap.tsx(tracked by [Frontend] Fix the react-hooks/exhaustive-deps warning in Map.tsx #1440), unrelated to this change./leaflet/marker-icon-2x-green.pngand no longer contain the CDN hostnames.npm run start+curl:/leaflet/marker-icon-2x-green.png,/leaflet/marker-icon-2x-blue.pngand/leaflet/marker-shadow.pngall returnHTTP 200 image/png, and/mapreturnsHTTP 200- i.e. markers render without any third-party host.Closes #1441
Closes #1442
Closes #1443
Closes #1444