Repository navigation
Add .nvmrc + engines, ignore pycache, remove .pyc files, delete empty Chart.yaml - #1531
Merged
BigBen-7 merged 2 commits intoOct 17, 2026
Conversation
…Chart.yaml - PinSpace-Org#1465: Add .nvmrc (node 20) and engines.node >=20 to root, Backend, Frontend, and analytics package.json - PinSpace-Org#1466: Add __pycache__/ and *.py[cod] to .gitignore - PinSpace-Org#1467: git rm --cached tracked .pyc files in infrastructure/scripts/__pycache__/ - PinSpace-Org#1468: Delete empty infrastructure/k8s/Chart.yaml (canonical chart is at k8s/helm/gistpin/Chart.yaml) Closes PinSpace-Org#1465 Closes PinSpace-Org#1466 Closes PinSpace-Org#1467 Closes PinSpace-Org#1468
|
@Femaleotaku Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four repository hygiene issues:
Changes
[Repo] Declare the supported Node.js version (.nvmrc and engines) #1465 — Added root
.nvmrc(node 20) andengines.node: >=20to root, Backend, Frontend, and analyticspackage.jsonfiles. READMEs and CI already specify Node 20; this enforces it.[Repo] Ignore Python bytecode (__pycache__ and *.pyc) #1466 — Added
__pycache__/and*.py[cod]to.gitignoreso Python bytecode is no longer committable.[Repo] Remove the committed .pyc files from infrastructure/scripts #1467 —
git rm --cachedthe two tracked.pycfiles (notify-changes.cpython-313.pycandparse-tf-plan.cpython-313.pyc) frominfrastructure/scripts/__pycache__/.[Infra] infrastructure/k8s/Chart.yaml is empty, so the Helm templates cannot be used #1468 — Deleted the empty
infrastructure/k8s/Chart.yaml. The canonical Helm chart already exists atk8s/helm/gistpin/Chart.yamlwith valid content. The empty file was preventinghelm lintfrom working on the templates directory.Closes #1465
Closes #1466
Closes #1467
Closes #1468