Release v0.5.5 - #43
Merged
Merged
Conversation
Where `ps` may not run, as in Codex's `workspace-write` sandbox on macOS, the web app template's `make serve` started a server it could not record and reported it as exited, and `make stop` took a running server for another process and dropped its record, so nothing could stop it. Both now refuse as `refused: no-ps` with the record kept, a running group `lsof` cannot see is refused the same way as `no-lsof`, and any server serve or stop meant to stop and could not is reported as `failed: still-running` with its record kept instead of as stopped. The lifecycle tests skip where `ps` may not run, so the template's `make all` passes in that sandbox. Closes L-260923-e82e4a 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes `make serve` and `make stop` where `ps` may not run, as in Codex's `workspace-write` sandbox on macOS. Previously `make serve` started a server it couldn't record and reported it as exited, and `make stop` could take a running server for another process, drop its record, and leave it listening with no way to stop it. Both now refuse as `refused: no-ps` without signaling anything, keeping the record. **Bug Fixes** - `make serve` checks it can read a start time before starting anything and refuses with `refused: no-ps` otherwise. - `make stop` refuses as `no-ps` or `no-lsof` while a recorded group still runs but can't be identified, keeping the record; a group that has ended is still cleared. - A server that couldn't be stopped, because the system refused the signal or it outlived `SIGKILL`, is reported `failed: still-running` with its record kept instead of `stopped`. - Lifecycle tests skip where `ps` may not run, so `make all` passes in that sandbox. Closes L-260923-e82e4a <sup>Written for commit d9647b9. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/Pipelex/pipelex-method-apps/pull/42?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.5.5
Bumps version from
0.5.4to0.5.5. Promotesdev→main.Changelog
Fixed
make servewherepsmay not run: in a sandbox that refusesps, as Codex'sworkspace-writesandbox does on macOS, the web app template'smake servenow refuses withrefused: no-psbefore starting anything, where it used to start the server, stop it again and reportfailed: exitedas if it had exited at once.make stopkeeps the record of a server it cannot identify: while the recorded server's first process runs wherepsmay not, or its group runs wherelsofsees none of its processes,make stopnow refuses and keeps.serve/state.json, where it used to take the server for another process or for one that had ended, drop its record and reportnot-runningwhile it still listened. The record of a server that has ended is still cleared.failed: still-running: a server thatmake serveormake stopmeant to stop and could not, because the system refused the signal or it outlivedSIGKILL, is now reported asfailed: still-runningwith its record kept, where it used to be reported as stopped and its record dropped.make allwherepsmay not run: a project's tests now skip the cases that start a server wherepsmay not run, so itsmake allpasses in such a sandbox instead of failing.Closes L-260925-f7be21
🤖 Generated with Claude Code
Summary by cubic
Releases v0.5.5, which fixes
make serveandmake stopwherepscannot run, as in Codex'sworkspace-writesandbox on macOS. Bumps the version from0.5.4to0.5.5and promotesdevtomain.make servenow refuses withrefused: no-psbefore starting anything when it cannot read a start time; it used to start the server, stop it again, and report it as exited.make stopkeeps.serve/state.jsonand refuses while a recorded server still runs but cannot be identified, where it used to drop the record and reportnot-running; a running grouplsofcannot see is refused asno-lsofthe same way, and records for ended servers are still cleared.SIGKILLis now reportedfailed: still-runningwith its record kept, instead of reported stopped.psmay not run, so the template'smake allpasses in such a sandbox.Closes L-260925-f7be21
Written for commit adc953b. Summary will update on new commits.