feature/Artifact-field-names · L-260924-27d936 - #43
Merged
Merged
Conversation
…rtifacts download_artifacts now names each saved file after the path of the field its reference fills, following the rule in pipelex-sdk-js's docs/artifact-download.md, and every verdict item carries found_at on both arms. locate_artifacts returns each reference with every $-rooted path it sits at, and artifact_filename takes an ArtifactLocation, so a verdict item predicts its own saved name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KAUFtFH3dukuR2CkwoH9wv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download_artifactsnow names each saved file after the field it fills, following the rulepipelex-sdk-jsstates in itsdocs/artifact-download.md, and every verdict item carriesfound_aton both arms. The newlocate_artifactsreturns each reference with every path it sits at, andartifact_filenamenow takes that location, so a verdict item predicts its own saved name. A cross-SDK run of one corpus through both implementations found no difference in the paths or the names.Closes L-260924-27d936
Advances L-260924-ec45a1
🤖 Generated with Claude Code
https://claude.ai/code/session_01KAUFtFH3dukuR2CkwoH9wv
Summary by cubic
download_artifactsnow names each saved file after the field it fills, matching the rulepipelex-sdk-jsdocuments, and every verdict item carriesfound_aton both arms. A newlocate_artifactsreturns eachpipelex-storage://reference together with every$-rooted path it sits at, in the same discovery order ascollect_artifacts, so a consumer can predict a saved filename before downloading. A cross-SDK run of one corpus through both implementations found no difference in the paths or the names.artifact_filenamenow takes anArtifactLocationand scope instead of a URI and index, and files are named from the first path at which their reference sits (for example,$.rooms[3].staged_photo.urlis saved asrooms-3-staged_photo.png).Breaking changes
artifact_filename(location, content_type, scope)replaces the old URI-based signature and raisesArtifactOperationErrorfor anything that is not a valid location.DownloadedArtifactnow extendsArtifactLocationand requiresfound_at; code that builds verdict items, such as test fakes, must supply it.Closes L-260924-27d936. Advances L-260924-ec45a1.
Written for commit 8068c41. Summary will update on new commits.