feature/Qualify-starters-pipecode · L-260924-765858 - #1
Merged
Merged
Conversation
Every demo command, in all three modes, now sends the pipe as the bundle's domain plus its main pipe (extract_entities.extract_entities) instead of the bare code. The runtime resolves the qualified form as an exact key, while a bare code is searched across every domain of the bundle and fails as ambiguous once two domains declare it, and the demos are the code users copy. The qualified form couples each call site to its bundle's domain, so test_mode_symmetry.py now reads the reference from each bundle and checks every demo in every mode against it. The e2e tests, the status fixture (the platform records the pipe_code a run was started with), the docs and the changelog follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7PSUoKkQLc7VcS7AkFJkM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every demo command, in all three modes, now sends its pipe as the bundle's qualified reference (
extract_entities.extract_entities) instead of the bare code. The runtime resolves that as an exact key, while a bare code is searched across the bundle's domains and fails as ambiguous once two of them declare it. A new test intests/unit/test_mode_symmetry.pyreads each bundle'sdomainandmain_pipeand checks every demo's call site against them. The live e2e tests pass with the qualified code onexecuteand onstart.Closes L-260924-765858
🤖 Generated with Claude Code
https://claude.ai/code/session_01N7PSUoKkQLc7VcS7AkFJkM
Summary by cubic
Changes every demo command, in all three modes, to send its pipe as the bundle's qualified reference (
domain.pipe_code, e.g.extract_entities.extract_entities) instead of the bare code, so the runtime resolves an exact key. A bare code is searched across every domain of the bundle and fails as ambiguous once two domains declare it.The qualified form ties each call site to its bundle's
domain, so renaming the domain now requires renaming the call sites together; detachedstatuslikewise reports the qualified pipe code, matching what the platform records when a run is started.tests/unit/test_mode_symmetry.pyreads each bundle'sdomainandmain_pipeand fails when a demo's call site no longer matches, and the e2e and unit tests, docs, and changelog are updated to the qualified references.Written for commit 3643b25. Summary will update on new commits.