Conversation
The human validation panel and the shared Markdown prose (agent CLI, fix's remaining errors, the /validate rendered_markdown) printed an unsafe suggested fix exactly like a safe one. One suggested_fix_label now reads "Suggested fix" for a safe fix and "Suggested fix (unsafe, confirm before applying)" for an unsafe one, such as rename-model, and the validate, fix, agent CLI and error-model docs say how an unsafe fix is shown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The FixSafety docstring no longer promises an opt-in that does not exist, and validate.md says the automatic-fix footer counts only safe fixes whose file the command may write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Review, round 3 at profile 4, bar necessity (cubic, codex review, codex adversarial, code-review medium): clean, nothing fixed or deferred. Earlier rounds: round 1 at profile 2 was clean; round 2 at profile 4 fixed the FixSafety docstring and the validate.md footer wording in 97bf0b8. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The human validation panel and the shared Markdown prose (the agent CLI, the remaining errors of
fix, and the/validaterendered Markdown) printed an unsafe suggested fix exactly like a safe one, so nobody could tell thatrename-modelneeds checking before it is applied. One shared label now reads💡 Suggested fix (unsafe, confirm before applying):for an unsafe fix while a safe fix keeps💡 Suggested fix:, and the validate, fix, agent CLI and error-model docs, with theFixSafetydocstring, say how an unsafe fix is shown and thatpipelex fix bundlenever applies it.Closes L-260926-8a069f
🤖 Generated with Claude Code
Summary by cubic
Unsafe suggested fixes now print a distinct label everywhere they appear, so a
rename-modelfix no longer looks identical to a safe one thatpipelex fix bundlewould apply on its own.💡 Suggested fix (unsafe, confirm before applying):for unsafe fixes across the human validation panel, the agent CLI Markdown, the/validaterendered Markdown, andfix's remaining errors.FixSafetydocstring now describe how unsafe fixes are labeled and thatpipelex fix bundlenever applies them.Written for commit 97bf0b8. Summary will update on new commits.