Skip to content

Add country-specific aliases for DO and PE - #58

Closed
taos15 wants to merge 1 commit into
PiratesIRC:mainfrom
taos15:main
Closed

taos15 wants to merge 1 commit into
PiratesIRC:mainfrom
taos15:main

Conversation

@taos15

@taos15 taos15 commented Sep 23, 2026

Copy link
Copy Markdown

What this changes

Adds country-specific aliases for the Dominican Republic (DO) and Peru (PE), enhancing localization support.

Why

This change improves user experience by providing more relevant identifiers for users in these countries.

Fixes #

How it was verified

  • python -m pytest -q passes
  • Live system

Anything a reviewer should know

No significant trade-offs or uncertainties were encountered during this implementation.


Please confirm:

  • No provider credentials, stream URLs, M3U account names or server addresses appear in the diff, the description, or any attached output.
  • The version was bumped with python scripts/bump_version.py, or this change does not need a version bump.

@PiratesIRC

Copy link
Copy Markdown
Owner

Thanks for adding the Dominican Republic and Peru aliases and channel databases. I made a few fixes and could not push them to your branch, so your commit and mine are together in #61. Your commit is included unchanged with your name on it. I am closing this one in favour of #61.

What I changed:

  1. Removed DR_channels.json. It was a copy of DO_channels.json with the country code set to DR. The plugin tags each channel with the code of the database it came from, and a DR: stream prefix is already read as DO. So with DR selected, Dominican streams looked foreign under Restrict Matching To Same Country. With All selected, the two files disagreed for all 309 channels and the database country was dropped for each of them. DO_channels.json on its own covers both prefixes.
  2. Removed the second entry of Teleunión, Entelevisión and ESPN 2 from DO_channels.json, each repeated under the HD category.
  3. Left the existing US entries in aliases.py as they were, because the reformatting did not change any values, so the diff now adds only your DO and PE sections.

One thing to know when testing: the country aliases apply only when Channel Database is set to exactly DO or PE. With All selected none of the country aliases are used. That is how the plugin works today for every country, not something your change caused.

@PiratesIRC PiratesIRC closed this Sep 25, 2026
PiratesIRC added a commit that referenced this pull request Sep 25, 2026
Add country-specific aliases for DO and PE (from #58, with review fixes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants