Merge pull request #96 from PlotPyStack/fix/95-std-icons-hidpi

Sharp Save as, Help, Open and Save items icons with display scaling

Author: PierreRaybaut

doc/release_notes/release_2.12.md

@@ -9,6 +9,7 @@
 * **Blurry icons with display scaling** — PlotPy's icons (toolbar tools, item list, curve, marker and line styles, brush patterns, ...) were 16×16 pixel PNG images, which looked blurry with a display scaling greater than 100 % (e.g. 125 %, 150 %, 200 %). They are now SVG images, which remain sharp at any display scaling. Applications requesting a PlotPy icon by its former PNG name (e.g. `get_icon("csection.png")`) still get it with guidata 3.17.1 or later, whose `get_image_file_path` falls back to the SVG image with the same name. The notices of the original artwork are provided in `plotpy/data/icons/LICENSES.txt` (fixes [Issue #91](https://github.com/PlotPyStack/PlotPy/issues/91))
 * **Icon name conflicts** — Several PlotPy icons share their names with icons of guidata or of applications (e.g. `image.svg`, `histogram.svg`, `apply.svg`, `delete.svg`): with guidata 3.17.1, which gives precedence to the icons of applications and warns about ambiguous image names, PlotPy designates these icons explicitly (e.g. `"plotpy:image.svg"`, `"guidata:apply.svg"`), so that its widgets keep their icons in applications. The icons that were exact copies of guidata icons (editors, file types, ...) are no longer shipped by PlotPy, which uses those of guidata (fixes [Issue #93](https://github.com/PlotPyStack/PlotPy/issues/93))
 * **Image lock tool icon** — The "Lock" tool of transformable images showed the "not found" icon until an image was selected: it now shows the lock icon
+* **Blurry Save as, Help, Open and Save items icons** — With a display scaling greater than 100 % (e.g. 150 %, 200 %), the icons of these tools were blurry, as their standard Qt icon was frozen to a 16-pixel image upscaled to the toolbar icon size: they now keep all the resolutions of the icon and are shown at the same size as the other toolbar icons (fixes [Issue #95](https://github.com/PlotPyStack/PlotPy/issues/95))
 
 ⚡ Performance:
 

plotpy/tools/item.py

@@ -307,7 +307,7 @@ def __init__(
         super().__init__(
             manager,
             _("Save items"),
-            get_std_icon("DialogSaveButton", 16),
+            get_std_icon("DialogSaveButton"),
             toolbar_id=toolbar_id,
         )
 

plotpy/tools/misc.py

@@ -32,7 +32,7 @@ def __init__(self, manager, toolbar_id=DefaultToolbarID):
         super().__init__(
             manager,
             _("Save as..."),
-            get_std_icon("DialogSaveButton", 16),
+            get_std_icon("DialogSaveButton"),
             toolbar_id=toolbar_id,
         )
 
@@ -257,7 +257,7 @@ def __init__(self, manager, toolbar_id=DefaultToolbarID):
         super().__init__(
             manager,
             _("Help"),
-            get_std_icon("DialogHelpButton", 16),
+            get_std_icon("DialogHelpButton"),
             toolbar_id=toolbar_id,
         )
 
@@ -327,7 +327,7 @@ def __init__(
         self, manager, title=_("Open..."), formats="*.*", toolbar_id=DefaultToolbarID
     ):
         super().__init__(
-            manager, title, get_std_icon("DialogOpenButton", 16), toolbar_id=toolbar_id
+            manager, title, get_std_icon("DialogOpenButton"), toolbar_id=toolbar_id
         )
         self.formats = formats
         self.directory = ""