Repository navigation
Fix/optional numeric check value - #115
Closed
ThomasMalletCodra wants to merge 7 commits into
Closed
ThomasMalletCodra wants to merge 7 commits into
ThomasMalletCodra wants to merge 7 commits into
Conversation
Add layout-scoped sliders for bounded numeric items while preserving exact text input and explicitly configured slider behavior.
…on, add release notes Address pre-review findings on feat/automatic-dataset-sliders: * HistogramRangeItem: align docstring and reference doc with the actual rendering behavior — bins are always drawn uniformly across `domain`; non-uniform `bin_edges` were documented but never consumed by `_HistogramCanvas.paintEvent`. Drop the fictive key from the two test fixtures that referenced it. * conv.py: document the `data.transient` exclusion from JSON/dict serialization introduced by HistogramRangeItem. * Add `test_histogram_range_canvas_paints_every_branch`, covering `_HistogramCanvas.paintEvent` for both presentations and three payload shapes (normal, empty selection, inverted domain). Raises guidata/dataset/qtitemwidgets.py coverage from 81% to 84%. * Add missing docstrings on test_loadsave_json.py (Pylint C0115/C0116). * Add `# guitest: show` demo entry points to test_auto_sliders.py and test_histogram_range_item.py for manual visual validation via `python -m guidata.tests`. * Add release notes for 3.16.0 (auto_sliders, HistogramRangeItem).
feat(dataset): add reactive numeric range editors
* [UPDATE] : guidata/dataset/dataitems.py:
- NumericTypeItem.check_value accepts None when allow_none=True
- IntItem.check_value skips the parity check for None
* [ADD] : guidata/tests/unit/test_optional_numeric_check.py:
- test optional int/float items accept None (empty field)
- test non-None values keep min/even constraints
- test required items keep rejecting None
- test DataSetEditLayout accepts empty optional numeric fields
* [UPDATE] : doc/release_notes/release_3.16.md:
- add bug fix entry for empty optional numeric fields
Assisted by : Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.