Repository navigation
README: install from git, and who built it - #4
Merged
Merged
Conversation
`pip install "plugrl-bridges[sb3]"` cannot work: the package is not on PyPI. The install line now points at the repository. A Who section names Chenhao Lu, Zuo Gou and Zilin Kang, as pyproject's authors and the organisation profile do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two README fixes, to have in place before this repository goes public.
Install from git.
pip install "plugrl-bridges[sb3]"cannot work, because the package is not on PyPI. The install line now points at the repository:pip install "plugrl-bridges[sb3] @ git+https://github.com/PlugRL/plugrl-bridges.git". The dependency on plugrl-protocol is already a git reference inpyproject.toml, so a git install resolves.Who. The README named no authors, and GitHub's contributor list shows only tactino. A Who section now names Chenhao Lu, Zuo Gou and Zilin Kang, the same as
pyproject.toml's authors and the organisation profile.