Update rust compiler - #2007
Update rust compiler#2007Neopallium wants to merge 9 commits into
Conversation
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
a50b557 to
5c201af
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Critical unresolved DART source changes and moderate toolchain/Wasmer compatibility issues must be addressed.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the repository to Rust nightly 2026-09-01 with compatibility changes across runtime, worker, RPC, and integration workspaces.
Changes:
- Updates toolchain pins, CI images, and coverage commands.
- Adds recursion limits and modernizes deprecated numeric APIs.
- Updates dependency features, DART branches, Wasmer constraints, and lockfiles.
File summaries
| File | Summary |
|---|---|
worker/protocol/dart-v1/src/lib.rs |
Adds recursion limit. |
worker/Cargo.toml |
Adjusts Wasmer constraints. Moderate (1 vote): <=7.1.0 permits older releases; use exact or explicit bounds. |
src/lib.rs |
Adds recursion limit. |
scripts/coverage.sh |
Updates nightly toolchain commands. |
rust-toolchain.toml |
Pins nightly 2026-09-01. Moderate (1 vote): the eth-rpc Docker builder remains on a stale compiler image. |
pallets/validators/src/tests.rs |
Modernizes maximum-value APIs. |
pallets/runtime/tests/src/transaction_payment_test.rs |
Modernizes maximum-value constants. |
pallets/runtime/tests/src/storage.rs |
Modernizes priority constants. |
pallets/runtime/tests/src/committee_test.rs |
Applies formatting compatibility fix. |
pallets/runtime/tests/Cargo.toml |
Enables default test utility features. |
pallets/runtime/testnet/src/runtime.rs |
Modernizes priority constant usage. |
pallets/runtime/mainnet/src/runtime.rs |
Modernizes priority constant usage. |
pallets/runtime/develop/src/runtime.rs |
Modernizes priority constant usage. |
pallets/runtime/common/src/lib.rs |
Modernizes priority constant usage. |
pallets/multisig/src/lib.rs |
Modernizes maximum-value constants. |
pallets/confidential-assets/src/lib.rs |
Adds recursion limit. |
node-rpc/Cargo.toml |
Enables default RPC dependency features. |
metadata-tools/Cargo.lock |
Refreshes locked dependencies. |
integration/tests/confidential_transfers.rs |
Adds recursion limit. |
integration/tests/confidential_transfers_negative.rs |
Adds recursion limit. |
integration/src/lib.rs |
Adds recursion limit. |
integration/src/bin/tools.rs |
Adds recursion limit. |
integration/rust-toolchain.toml |
Pins nightly 2026-09-01. |
integration/Cargo.toml |
Switches DART sources to dart-v0.1.0. Critical (1 vote): this cryptographic source change requires reversion or separate explanation and validation. |
Cargo.toml |
Switches runtime DART and cryptographic sources to dart-v0.1.0. Critical (2 votes): this protocol-affecting change requires reversion or separate documentation and validation. |
.circleci/config.yml |
Updates CI compiler images. |
Review details
Suppressed comments (3)
integration/Cargo.toml:44
- The integration workspace is likewise switched from the
main/polymesh-masterdependency sources todart-v0.1.0, which can change the cryptographic test client and generated proof behavior. This is not explained by the compiler-only PR description; please revert it or explicitly scope and validate the integration dependency migration.
polymesh-dart = { git = "https://github.com/PolymeshAssociation/polymesh-dart", branch = "dart-v0.1.0" }
polymesh-dart-bp = { git = "https://github.com/PolymeshAssociation/polymesh-dart", branch = "dart-v0.1.0" }
polymesh-dart-common = { git = "https://github.com/PolymeshAssociation/polymesh-dart", branch = "dart-v0.1.0" }
rust-toolchain.toml:2
- This updates the repository toolchain, but
.docker/eth-rpc/Dockerfile.local:1still defaults todebian-nightly-2025-12-01. That Dockerfile copies this repository and runs a locked Cargo build, so local eth-rpc image builds now start from a stale compiler image (or require rustup to fetch the new one); update that builder image in the same change or derive it from this pin.
channel = "nightly-2026-09-01"
worker/Cargo.toml:31
<=7.1.0permits Cargo to select any older Wasmer release, not just the 7.1.0 release currently recorded in the lockfile. If the lockfile is regenerated after a release is yanked or in another workspace, an older major/minor API may be selected and the backend can stop compiling; use an exact=7.1.0requirement (or an explicit lower and upper bound) for the tested compatibility range.
wasmer = { version = "<=7.1.0", optional = true }
wasmer-compiler-cranelift = { version = "<=7.1.0", optional = true }
wasmer-compiler-llvm = { version = "<=7.1.0", optional = true }
- Files reviewed: 25/28 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
changelog
other
dart-v0.1.0branch for DART dependencies (this matches the version used before).