README.asc: fix stale docs, document undocumented API surface - #74
Open
jnasbyupgrade wants to merge 4 commits into
Open
README.asc: fix stale docs, document undocumented API surface#74jnasbyupgrade wants to merge 4 commits into
jnasbyupgrade wants to merge 4 commits into
Conversation
Follow-up from the pgxntool-test API documentation review process (Postgres-Extensions/pgxntool-test#42), which found several places where README.asc no longer matched the code, plus several targets and variables with no documentation at all. Corrections to existing docs: - 'test' prerequisites: no longer depends on clean (removed a while back because it broke incremental/watch-based builds); mention the conditional test-build dependency. - verify-results safeguard: only documented the regression.diffs check, not the actual default (pgtap mode, which scans test output for TAP failures first); document PGXNTOOL_VERIFY_RESULTS_MODE. - tag: dropped the incorrect 'annotated' claim (it's a lightweight tag), and documented the skip-if-already-at-HEAD idempotency that isn't mentioned anywhere. - run-pgtle: corrected the claimed check-pgtle make dependency, which doesn't exist -- the check happens inside pgtle.sh itself. - Document Rules: fixed the installcheck typo and corrected how html actually gets wired into install/installcheck (via all, not directly). - ASCIIDOC_template code sample: matched the actual ifeq/strip check in base.mk instead of the old ifndef version. New documentation for previously-undocumented items: - dist/dist-only: the .gitattributes-must-be-committed safety check, and forcedist. - list and print-%, pgxntool's own dev-helper targets. - docclean. - PGXNTOOL_NO_PGXS_INCLUDE. - pgtle.sh's own CLI flags (--get-version, --get-dir, --run), not just the make targets that wrap them. Deliberately left undocumented per review: EXTRA_CLEAN += pg_tle/ (not worth a doc entry), and the internal conditional helper targets (clean-test-build, the install-schedule file target) that aren't meant to be invoked by hand.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
git subtree pull copies pgxntool's entire tree into the consumer project, including dev-only directories that don't belong there. prune_pgxntool_dev_dirs() (lib.sh) has silently removed these after every sync since Postgres-Extensions#41, but the behavior was never documented anywhere -- surfaced by the pgxntool-test API documentation review (Postgres-Extensions/pgxntool-test#42).
… summary Point to the existing testdeps/test-build sections and call out PGXNTOOL_ENABLE_TEST_BUILD instead of listing exact prerequisite targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jnasbyupgrade
marked this pull request as ready for review
July 27, 2026 23:35
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from the new API documentation review process added in Postgres-Extensions/pgxntool-test#42. That PR's dry run compared
README.ascagainst the actual code and found several real gaps — this PR fixes them.Corrections to existing docs (README described something code no longer does, or never did):
test's prerequisites no longer includeclean(removed a while back — it broke incremental/watch-based builds); README still listed it. Also documents the conditionaltest-builddependency.verify-resultssafeguard only documented theregression.diffscheck; the actual default (PGXNTOOL_VERIFY_RESULTS_MODE=pgtap) scans test output for pgTAP failures first, falling back toregression.diffs. Documents the variable and both modes.tag: dropped the claim that it creates an annotated tag (it'sgit tag NAME— lightweight), and documented the skip-if-already-at-HEAD idempotency, which wasn't mentioned anywhere.run-pgtle: corrected the claimed make-level dependency oncheck-pgtle— that check actually happens insidepgtle.shitself at runtime.installchecktypo and corrected howhtmlactually gets wired in (viaall, not directly as a prerequisite ofinstall/installcheck).ASCIIDOC_templatecode sample: matched the realifeq (,$(strip $(ASCIIDOC)))check inbase.mk— the doc still showed an oldifndef ASCIIDOCversion.New documentation for previously-undocumented items:
dist/dist-only: the.gitattributes-must-be-committed safety check, andforcedist.listandprint-%— pgxntool's own dev-helper targets.docclean.PGXNTOOL_NO_PGXS_INCLUDE.pgtle.sh's own CLI flags (--get-version,--get-dir,--run), not just the make targets that wrap them.pgxntool-sync: documents that every sync silently prunespgxntool/.githubandpgxntool/.claudefrom the consumer project (prune_pgxntool_dev_dirs()inlib.sh, added in Add Claude Code GitHub Actions workflows #41) — this had never been mentioned anywhere.Deliberately left undocumented (per review):
EXTRA_CLEAN += pg_tle/(not worth a doc entry), and the internal conditional helper targets (clean-test-build, the install-schedule file target) that aren't meant to be invoked by hand.No code changes — doc-only, so no
HISTORY.ascentry.Flag for review: the
.gitattributes-must-be-committed note underdistdocumentsdist-only's existing safety check based on reading its implementation — please confirm the explanation is accurate.Test plan
asciidoctor README.ascrenders clean with no new warnings (one pre-existing unrelated xref warning,_Document_Handling, predates this change).base.mk/pgtle.sh/lib.shsource.🤖 Generated with Claude Code