Repository navigation
Compilers version bump - #1631
Merged
Merged
Conversation
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
mgovers
reviewed
Oct 7, 2026
mgovers
previously approved these changes
Oct 7, 2026
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Member
Author
|
Added |
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
figueroa1395
commented
Oct 16, 2026
figueroa1395
commented
Oct 16, 2026
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
TonyXiang8787
previously approved these changes
Oct 16, 2026
figueroa1395
enabled auto-merge
October 16, 2026 10:15
figueroa1395
disabled auto-merge
October 19, 2026 08:33
mgovers
reviewed
Oct 19, 2026
Co-authored-by: Martijn Govers <martijn.govers@alliander.com> Signed-off-by: Santiago Figueroa Manrique <22895394+figueroa1395@users.noreply.github.com>
mgovers
approved these changes
Oct 19, 2026
figueroa1395
enabled auto-merge
October 19, 2026 09:09
|
bferanmi806-sketch
added a commit
to bferanmi806-sketch/power-grid-model
that referenced
this pull request
Oct 21, 2026
- Bump GCC/G++ to 16 and Clang to 22, matching CI after PowerGridModel#1631. - Isolate cpp_build in a per-checkout Docker volume so host-generated CMakeCache.txt files cannot break presets such as clang-debug. - Add and configure the clang-format extension, using the version pinned in uv.lock so editor formatting matches CI. - Install uv and document pre-commit, formatting and REUSE workflows. - Document how to verify the selected compiler and reset the build volume.
bferanmi806-sketch
added a commit
to bferanmi806-sketch/power-grid-model
that referenced
this pull request
Oct 21, 2026
Provide a separately selectable C++ development container alongside the default Python container (issue PowerGridModel#1272). The container is based on Ubuntu 26.04 and mirrors the Linux CI toolchain after PowerGridModel#1631: gcc-16/g++-16, clang-22, clang-tidy-18, CMake, Ninja, gdb and the C++ dependencies from the build guide (boost, eigen3, nlohmann-json, msgpack-cxx, doctest). It reuses the gcc-debug/clang-debug CMake presets and the existing VS Code debug configurations. cpp_build is kept in a per-checkout Docker volume. CMake caches contain absolute paths, so sharing that directory with the host made presets fail with a CMakeCache.txt directory mismatch (reported for clang-debug). The clang-format extension uses the version pinned in uv.lock, which is the same version CI runs through pre-commit, and the documentation now covers formatting, REUSE, pre-commit and compiler verification. Signed-off-by: Balogun Feranmi <bferanmi806@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the CI runners being bumped to Ubuntu 26.06 in #1628, it's only natural that we bump the compilers to the newest supported versions. See the GitHub's Ubuntu 26.05 readme for more information.
The new defaults are:
gcc/g++ 15- ubuntu docs.clang 21- ubuntu docs.But we can already bump to
gcc/g++ 16andclang 22, as those are the latest available versions.I did not upgrade
clang-tidyon purpose as this will mean larger changes. However, note thatclang-tidy 22is now available as "default" as well.Note: There seems to be a bug/regression in
clang-22as stated in #1631 (comment). So a few adjustments needed to be done in this PR for us to migrate. That said, the issue is known (see llvm/llvm-project#162023) and the fix is equally valid, so we don't need to do anything about it.