Implement unimplemented concurrency methods for all server classes#2012
Open
alerickson wants to merge 11 commits into
Open
Implement unimplemented concurrency methods for all server classes#2012alerickson wants to merge 11 commits into
alerickson wants to merge 11 commits into
Conversation
alerickson
requested review from
SydneyhSmith,
adityapatwardhan,
anamnavi and
shammu1
as code owners
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR continues the concurrent install/find work by implementing previously-stubbed async methods across server API call classes and by broadening the gating so the concurrent code paths can be used for more repository types (beyond V2).
Changes:
- Implemented
Find*AsyncandInstallPackageAsyncoverrides for V3, NuGet server, local repo, and container registry server classes. - Added async install helpers for V3 (including async HTTP content fetch) to support parallel install workflows.
- Expanded the concurrency gating in
FindHelperandInstallHelperso parallelism can be used across more API versions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/code/V3ServerAPICalls.cs | Implements async find/install methods and adds async install/HTTP helpers for V3 repositories. |
| src/code/NuGetServerAPICalls.cs | Implements async wrappers for find/install methods for NuGet V2-style servers. |
| src/code/LocalServerApiCalls.cs | Implements async find/install methods for local repository server. |
| src/code/InstallHelper.cs | Broadens parallel install gating to apply regardless of repository API version. |
| src/code/FindHelper.cs | Broadens parallel find/dependency gating and routes more paths through async methods. |
| src/code/ContainerRegistryServerAPICalls.cs | Implements async wrappers for find/install methods for container registry server. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
InstallPackageAsync was calling the synchronous InstallPackage() which writes to _cmdletPassedIn.WriteDebug, causing cross-thread cmdlet stream writes when used from Parallel.ForEach. - Refactor InstallPackageAsync to not call InstallPackage(); inline the null-version check and enqueue all messages via the provided queues - Add a queue-aware InstallVersion overload that uses ConcurrentQueue parameters instead of _cmdletPassedIn.Write* calls, for use by the async install path - Keep the original InstallVersion(out ErrorRecord) overload intact for the synchronous path
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alerickson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a continuation of the concurrency work started in PR #1950. This PR adds concurrent/parallel execution support across all PSResourceGet server API classes by implementing the previously-stubbed async methods and broadening the API-version gating that selects the concurrent code path.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.