Repository navigation
Potential fix for code scanning alert no. 8: Slice memory allocation with excessive size value - #4
Draft
Pradyothsp wants to merge 1 commit into
Draft
Pradyothsp wants to merge 1 commit into
Pradyothsp wants to merge 1 commit into
Conversation
…with excessive size value I think, this needs to come from a config. Need to think more about this Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Pradyoth S P <56448288+Pradyothsp@users.noreply.github.com>
Owner
Author
|
We need to consider adding maxK to config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Pradyothsp/GoVec/security/code-scanning/8
The correct fix is to validate and cap user-controlled search size (
k) at the API boundary before invoking engine/index/graph search. This preserves existing behavior for valid requests while rejecting abusive values early with400 Bad Request.Best single fix (without changing intended functionality):
internal/api/handlers/vectors.go, insideVectorHandler.Search, add a maximum allowedkconstant and reject values above it.k > maxK.This prevents tainted oversized values from ever flowing into
fetchCount,resultCap, and slice capacity allocations.Suggested fixes powered by Copilot Autofix. Review carefully before merging.