Repository navigation
Make sketching canvas responsive - #30
Merged
Merged
Conversation
SybelBlue
reviewed
Sep 23, 2026
SybelBlue
left a comment
Collaborator
There was a problem hiding this comment.
Codex Code Review
Summary
The responsive canvas coordinate changes behave correctly, but the toolbar shrink algorithm introduces one substantial accessibility barrier on narrow layouts. The toolbar should retain usable control and text sizes before this is merged.
Priority rankings
- P0: 0
- P1: 0
- P2: 0
- P3: 0
- A0: 0
- A1: 0
- A2: 1
- A3: 0
Validation
- Reviewed the complete merge diff from
691099d168cc1a9cda759f6e010e1b9f71341b1athroughf9407f2d53773f782989e5346ea3f0bd30738f8c, the PR description, linked issue discussion, current PrairieLearn integration, and existing review activity. - All five GitHub CI checks are passing.
- Local ESLint, Prettier, and production Webpack build passed.
- Headless Chrome 153 confirmed responsive point placement and dragging map back to the expected SVG coordinates.
- At a 320px viewport, the provided
allPluginstoolbar rendered its first button at approximately18.2 × 25.8CSS pixels. - There is no automated JavaScript/browser interaction suite; manual browser validation was limited to Chrome.
Review configuration
- Model: not exposed by current runtime
- Thinking level (reasoning effort): not exposed by current runtime
Collaborator
|
Messing around with this further, it looks good to me! I'm excited to get this deployed... |
Collaborator
Author
|
I changed the menu bar so it doesn't scale the buttons but only consumes the whitespace and then adds a "More" item that has the overflowing items. Tested manually and reviewed by Claude. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the scaling issue brought up in PrairieLearn/PrairieLearn#14904 for both editable and read-only canvases. The former need some extra helpers to adjust pixel coordinates, but the change is not as major as I initially expected.
@SybelBlue @nwalters512 any thoughts on this? I've updated the debugging page (if you run
npm startinside thesketch_toolfolder) to mimic the PL question/submission panels, so it should be easy to try this out without loading it into PL.