Skip to content

Run Knip in CI - #36

Merged
nritschel merged 1 commit into
masterfrom
tools/ci/knip
Sep 24, 2026
Merged

nritschel merged 1 commit into
masterfrom
tools/ci/knip

Conversation

@SybelBlue

Copy link
Copy Markdown
Collaborator

Summary

  • run Knip as part of JavaScript CI
  • remove unused files and dependencies
  • retain intentional exports without changing runtime assets

Testing

  • npm run knip
  • npm run lint --workspace sketch_tool
  • npm run format:check --workspace sketch_tool
  • production runtime assets match master byte-for-byte

@SybelBlue
SybelBlue marked this pull request as ready for review September 24, 2026 17:08
@SybelBlue
SybelBlue requested a review from nritschel September 24, 2026 17:08
@SybelBlue

Copy link
Copy Markdown
Collaborator Author

Following #33 and #34, this isn't a huge leap. The CI config is pulled over from Pl/Pl. Feel free to reject if it adds too much overhead...

@nritschel nritschel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this repo doesn't have a ton of checks in place, adding ones that catch issues for free are certainly a good idea!

@nritschel
nritschel merged commit caf2e6d into master Sep 24, 2026
5 checks passed
@nritschel
nritschel deleted the tools/ci/knip branch September 24, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants