Repository navigation
Same 'not supplied' message for .studyAreaName as the other modules - #136
Merged
Merged
Conversation
…eaName message Each module worded this message slightly differently, or had none. The message now comes from reproducible (PredictiveEcology/reproducible#638), so it is the same everywhere. An older reproducible ignores the argument: same name, no message, so no version floor is needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
added
enhancement
Collaborator
Author
|
The message will not be shown until the version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user does not name their study area, this module makes up a name from the study area itself and says so. Each module worded that message slightly differently, or had none, so this is mostly about making the message the same across modules.
Affects: only the wording of that one message; the name that is made up is unchanged.
Technical details
The fallback is now
P(sim)$.studyAreaName <- reproducible::studyAreaName(<object>, notSupplied = ".studyAreaName"), guarded byis.null() || is.na(). reproducible prints "`.studyAreaName` not supplied; using a hash of ``: " (PredictiveEcology/reproducible#638). Before: "The .studyAreaName is not supplied; derived name from sim$studyArea_biomassParam: ", written in the module.No reproducible floor is needed: an older
studyAreaName()takesnotSuppliedin...and returns the same hash with no message (checked on 3.2.1.9063). NEWS.md updated. The module's own CI is the test; locally the module test setup fails the same way on unchanged development, so it says nothing about this change.🤖 Generated with Claude Code