Repository navigation
Release Biomass_borealDataPrep 1.8.0 - #137
Merged
Merged
Conversation
Removed URL assignment and switched to new dataSource Parameter. Currently set to KNN (function default) but could be changed to SCANFI in future.
Seems to have been done by gitkraken.
Biomass_borealDataPrep.R:130-131 hardcoded a Gaussian age ~ log(totalBiomass) * cover * speciesCode model, which predict() could push negative for young, high-cover, low-biomass stands; that was clamped to age 0 with biomass > 0, which CBMutils::cumPoolsCreateAGB() rejects (#131). The parameter now defaults to LandR::imputeBadAgeModelDefault(), which fits log(age) instead, and the LandR floor is raised to >= 1.2.0.9035 to require it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
LandR#248, which adds the function, is now 1.2.0.9039; 9035 no longer identifies it (development is already at 9038 without it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add crayon, curl, httr, lme4, Require and tidyterra to reqdPkgs; the module's code uses them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
…orealDataPrep chore: missing packages in reqdPkgs
pkg::fun() resolves without attaching or importing the package, and LandR already installs each of them; listed, they are attached for every module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # Biomass_borealDataPrep.R # NEWS.md
development reached 9042 without #248, so the 9039 floor no longer ensured imputeBadAgeModelDefault(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sponse-bdp imputeBadAgeModel default: use LandR::imputeBadAgeModelDefault()
…AndCleanInitialCohortData Needs LandR#264 (and its version bump to 1.2.0.9046). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NrcKsYkv9Qx5qU4JTxSzGN
… BC ELF) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NrcKsYkv9Qx5qU4JTxSzGN
…onShare minSpeciesEcoregionShare: remove species rare in an ecoregion (default 0.07)
Version 1.7.1.9002; keep both NEWS entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dev versions share one '# Biomass_borealDataPrep (development version)' heading, as use_news_md()/use_version() write it; release headings become '# Biomass_borealDataPrep x.y.z'. Text unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eaName message Each module worded this message slightly differently, or had none. The message now comes from reproducible (PredictiveEcology/reproducible#638), so it is the same everywhere. An older reproducible ignores the argument: same name, no message, so no version floor is needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Supplied Same 'not supplied' message for .studyAreaName as the other modules
reqdPkgs is the module's install list as well as its attach list, so packages called only as pkg::fun() stay listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed-only NEWS: usethis headings
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QewQ83bbo8r7SW4WceE29U
eliotmcintire
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the work on development into main as release 1.8.0. Main has not been updated since version 1.5.7, so this brings SCANFI inputs, the wetland layer, estimated deciduous cover weight and many fixes to starting parameters.
Affects: starting parameters (maxB, establishment, ages, vegetation types) change for most study areas; renamed inputs (
studyAreaLarge/rasterToMatchLarge->*_biomassParam) need project updates.Technical details
main..development: 256 commits;development..mainis empty, so the merge is clean.v1.8.0and the GitHub release follow, then development goes to 1.8.0.9000.🤖 Generated with Claude Code
https://claude.ai/code/session_01QewQ83bbo8r7SW4WceE29U