server: clear slot state on task cancellation - #103
Draft
khosravipasha with Copilot wants to merge 2 commits into
Draft
server: clear slot state on task cancellation#103khosravipasha with Copilot wants to merge 2 commits into
khosravipasha with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: khosravipasha <2780093+khosravipasha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CUDA illegal memory access crash at context 81920
server: clear slot state on task cancellation
Jul 31, 2026
There was a problem hiding this comment.
Pull request overview
Clears server slot prompt and KV state when completion tasks are cancelled.
Changes:
- Adds an optional prompt-clearing mode to slot release.
- Uses stronger cleanup for cancellation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+456
to
458
| if (clear_prompt || task->is_child()) { | ||
| prompt_clear(false); | ||
| } |
| for (auto & slot : slots) { | ||
| if (slot.task && slot.task->id == task.id_target) { | ||
| slot.release(); | ||
| slot.release(true); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Long-running completion requests could be cancelled while their slot still retained prompt/KV-backed context for a large context window. That stale state was being released without being fully cleared, leaving cancelled requests to leave behind partially alive slot state that is unsafe for later execution at high context depths. This PR makes cancellation explicitly drop the slot's prompt/context state before the slot is recycled.
Additional information
This targets the server slot reuse path used by long-running completions and is intended to harden cancellation under large-context, high-cache workloads without changing normal generation behavior.
Requirements
As an AI agent, I am not the repository maintainer; the user remains responsible for all submitted changes, and this project restricts AI-generated content.