Repository navigation
Conversation
getAssigneesFromExpression now handles array input from POST users_task_count, fixing 500 errors when REASSIGN_RESTRICT_TO_ASSIGNABLE_USERS is enabled. https://processmaker.atlassian.net/browse/FOUR-32830
Handle array input from POST users_task_count to prevent TypeError when REASSIGN_RESTRICT_TO_ASSIGNABLE_USERS is enabled. https://processmaker.atlassian.net/browse/FOUR-32830
|
QA server K8S was successfully deployed https://ci-fe9ffd1065.engk8s.processmaker.net |
…ay form_data Accept array form_data in getAssigneesFromExpression to prevent TypeError on users_task_count when REASSIGN_RESTRICT_TO_ASSIGNABLE_USERS is enabled. Expand group assignees via getConsolidatedUsers, flatten manager_id, and evaluate reassignment rules using BPMN assignment type instead of getAssignmentRule(). https://processmaker.atlassian.net/browse/FOUR-32830
PR SummaryMedium Risk Overview
The reassign UI removes client-side filtering of the current assignee; behavior is centralized in the API. Feature and model tests cover self-exclusion, rule expressions, empty matches, and groups. Reviewed by Cursor Bugbot for commit 0fc151a. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…signees Replace getAssignees plus in_array second pass with a single loop that evaluates each rule via isAssignmentRuleMatch. This prevents unmatched group rules from expanding when they share an assignee id with a matched user rule, and avoids losing group members when manager_id collides with sequential indexes from getConsolidatedUsers. - Merge group users into userIds keyed by user id - Reuse one ExpressionLanguage instance per loop - Add unit tests for assignee id collision and manager id collision cases https://processmaker.atlassian.net/browse/FOUR-32830
|
QA server K8S was successfully deployed https://ci-fe9ffd1065.engk8s.processmaker.net |
…sion reassignees Evaluate rule_expression reassignment filtering even when form_data is missing or empty, using persisted process request data as a fallback so expression rules still match after a task has been reassigned. - Always resolve rule_expression assignees in users_task_count when restriction is enabled - Eager-load processRequest for expression variable resolution - Add resolveExpressionVariables() to merge request data with submitted form_data - Add unit and feature coverage for empty form_data group reassignment scenarios https://processmaker.atlassian.net/browse/FOUR-32830
…n has no matches Fall back to persisted request data when form_data is empty so rule expression reassignment keeps working after a task is reassigned, and always apply the assignable filter even when no users match. - Resolve expression variables from processRequest.data when form_data is empty - Always evaluate rule_expression assignees when restriction is enabled - Eager-load processRequest for expression variable resolution - Apply whereIn whenever assignable filtering is active, including empty results - Add tests for empty form_data fallback and no-match empty list scenarios Fixes https://processmaker.atlassian.net/browse/FOUR-32830
|
QA server K8S was successfully deployed https://ci-fe9ffd1065.engk8s.processmaker.net |
…back Default assignment rules were always treated as a match alongside expression rules, so reassignment could include fallback users who would not receive the task under the current data. - Evaluate expression rules first and skip default rules in that pass - Apply default rules only when no expression rule matches - Extract isDefaultAssignmentRule() and appendAssignmentAssignees() helpers - Add regression test for default exclusion when an expression rule matches Fixes https://processmaker.atlassian.net/browse/FOUR-32830
|
QA server K8S was successfully deployed https://ci-fe9ffd1065.engk8s.processmaker.net |
…lude session user Evaluate assignment rule expressions with feelExpression() and resolve variables from the process instance datastore, matching initial task assignment behavior. Exclude the authenticated user from users_task_count when assignable_for_task_id is provided and remove the duplicate client-side filter from the reassign UI. Refs: https://processmaker.atlassian.net/browse/FOUR-32830
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8a9b76b. Configure here.
…r list Clarify why users_task_count excludes the authenticated user when assignable_for_task_id is present. This prevents self-reassignment in the reassign modal without changing assignment rule evaluation. Refs: https://processmaker.atlassian.net/browse/FOUR-32830
2026-09-25.10-41-53.mp4 |
|
5 participants
getAssigneesFromExpression now handles array input from POST users_task_count, fixing 500 errors when REASSIGN_RESTRICT_TO_ASSIGNABLE_USERS is enabled.
https://processmaker.atlassian.net/browse/FOUR-32830
ci:deploy