Skip to content

refactor: optimize group retrieval using query builder - #9064

Merged
nolanpro merged 1 commit into
developfrom
FOUR-33295-b
Sep 17, 2026
Merged

nolanpro merged 1 commit into
developfrom
FOUR-33295-b

Conversation

@caleeli

@caleeli caleeli commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

There is a string query building in the code that can be improved.

Solution

  • Use DB::table and whereIn to improve this query preparation.

Related Tickets & Packages

.

@caleeli
caleeli requested a review from pmPaulis September 17, 2026 13:50
@cursor

cursor Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Equivalent SQL with safer binding via the query builder; no change to assignment rules or user filtering logic.

Overview
When resolving nested group members for task assignment, active subgroup IDs are now loaded with Laravel’s query builder (DB::table('groups')->whereIn()->where('status', 'ACTIVE')->pluck('id')) instead of hand-built ? placeholders and a raw DB::select on groups.

The loop still pushes only those active subgroup IDs onto the pending queue for further member expansion; this is a query-style cleanup in a process-execution hot path, not a behavior change.

Reviewed by Cursor Bugbot for commit b6fd1d9. Bugbot is set up for automated code reviews on this repo. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nolanpro
nolanpro merged commit 41da510 into develop Sep 17, 2026
23 of 27 checks passed
@nolanpro
nolanpro deleted the FOUR-33295-b branch September 17, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants