Repository navigation
FOUR-33655: Reject OPTIONS requests to login - #9087
Open
eiresendez wants to merge 1 commit into
Open
eiresendez wants to merge 1 commit into
eiresendez wants to merge 1 commit into
Conversation
|
|
QA server K8S was successfully deployed https://tenant-1.ci-edb8662af6.engk8s.processmaker.net |
Contributor
|
The code looks good. No observations. |
CarliPinell
self-requested a review
October 6, 2026 14:22
CarliPinell
approved these changes
Oct 6, 2026
CarliPinell
left a comment
Contributor
There was a problem hiding this comment.
No observations were found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue & Reproduction Steps
Laravel automatically responds to
OPTIONS /loginwith HTTP 200 and anAllowheader. This behavior was reported as an HTTP OPTIONS exposure on the login endpoint.Solution
OPTIONS /loginroute that returns HTTP 405 with an empty response body.GET,HEAD, andPOSTas the allowed login methods.How to Test
Tests\Feature\RouteTest::testLoginDoesNotAllowOptions.OPTIONS /loginreturns HTTP 405 withAllow: GET, HEAD, POSTand an empty body.PHP syntax checks passed for the changed route and test files. The automated feature test was not run.
Related Tickets & Packages
ci:deploy